incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-177) SimplePageRankVertex has two redundant casts
Date Tue, 10 Apr 2012 10:41:18 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Devaraj K updated GIRAPH-177:
-----------------------------

    Attachment: GIRAPH-177.patch
    
> SimplePageRankVertex has two redundant casts
> --------------------------------------------
>
>                 Key: GIRAPH-177
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-177
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Priority: Trivial
>              Labels: newbie
>         Attachments: GIRAPH-177.patch
>
>
> {code}        DoubleWritable maxPagerank =
>             (DoubleWritable) maxAggreg.getAggregatedValue();
>         LOG.info("aggregatedMaxPageRank=" + maxPagerank.get());
>         DoubleWritable minPagerank =
>             (DoubleWritable) minAggreg.getAggregatedValue();
>         LOG.info("aggregatedMinPageRank=" + minPagerank.get());{code}
> Both MinAggregator and MaxAggregator are already parameterized on DoubleWritable, so
it's not necessary to cast their functions' results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message