incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-179) BspServiceMaster's PathFilter can be simplified
Date Tue, 10 Apr 2012 10:21:18 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Devaraj K updated GIRAPH-179:
-----------------------------

    Attachment: GIRAPH-179.patch
    
> BspServiceMaster's PathFilter can be simplified
> -----------------------------------------------
>
>                 Key: GIRAPH-179
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-179
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Priority: Trivial
>              Labels: newbie
>         Attachments: GIRAPH-179.patch
>
>
> {code}  /**
>    * Only get the finalized checkpoint files
>    */
>   public static class FinalizedCheckpointPathFilter implements PathFilter {
>     @Override
>     public boolean accept(Path path) {
>       if (path.getName().endsWith(
>           BspService.CHECKPOINT_FINALIZED_POSTFIX)) {
>         return true;
>       }
>       return false;
>     }
>   }{code}
> we can simplify this, eliminating the if statement and just returning the result of {{endsWith()}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message