Return-Path: X-Original-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7866397FC for ; Mon, 13 Feb 2012 20:47:24 +0000 (UTC) Received: (qmail 13568 invoked by uid 500); 13 Feb 2012 20:47:24 -0000 Delivered-To: apmail-incubator-giraph-dev-archive@incubator.apache.org Received: (qmail 13485 invoked by uid 500); 13 Feb 2012 20:47:23 -0000 Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: giraph-dev@incubator.apache.org Delivered-To: mailing list giraph-dev@incubator.apache.org Received: (qmail 13476 invoked by uid 99); 13 Feb 2012 20:47:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2012 20:47:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2012 20:47:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 29C3F1B4591 for ; Mon, 13 Feb 2012 20:47:00 +0000 (UTC) Date: Mon, 13 Feb 2012 20:47:00 +0000 (UTC) From: "Jakob Homan (Commented) (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: <446839648.33366.1329166020172.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1379497719.43990.1316471408970.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207185#comment-13207185 ] Jakob Homan commented on GIRAPH-40: ----------------------------------- bq. The below examples are what Checkstyle wants to have us do. So does that mean code not in that hideous style will be flagged by Checkstyle? I'm confused by the next example you posted, which says Checkstyle won't enforce indenting post line wrap... > Adding checkstyle enforcement of Giraph code conventions > -------------------------------------------------------- > > Key: GIRAPH-40 > URL: https://issues.apache.org/jira/browse/GIRAPH-40 > Project: Giraph > Issue Type: New Feature > Reporter: Avery Ching > Assignee: Avery Ching > Priority: Minor > Attachments: GIRAPH-40.patch > > > Now that we have some code conventions (see GIRAPH-21), we should enforce them with a maven checkstyle plugin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira