incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-132) Simplify boolean expression in GraphMapper::map()
Date Fri, 03 Feb 2012 13:51:53 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199706#comment-13199706
] 

Harsh J commented on GIRAPH-132:
--------------------------------

Unsure what you mean here -- is it to refine the comments or the way map() itself is implemented
per that?
                
> Simplify boolean expression in GraphMapper::map()
> -------------------------------------------------
>
>                 Key: GIRAPH-132
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-132
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Priority: Trivial
>              Labels: newbie
>
> The boolean expression in:
> {noformat}    @Override
>     public void map(Object key, Object value, Context context)
>         throws IOException, InterruptedException {
>         // map() only does computation
>         // 1) Run checkpoint per frequency policy.
>         // 2) For every vertex on this mapper, run the compute() function
>         // 3) Wait until all messaging is done.
>         // 4) Check if all vertices are done.  If not goto 2).
>         // 5) Dump output.
>         if (done == true) {
>             return;
>         }{noformat}
> can be simplified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message