incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-132) Simplify boolean expression in GraphMapper::map()
Date Fri, 24 Feb 2012 18:51:49 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215809#comment-13215809
] 

Eli Reisman commented on GIRAPH-132:
------------------------------------

This seems to have been fixed already but is still on this list. Don't know who did it. Looking
at GraphMapper::map() I see this:

@Override
  public void map(Object key, Object value, Context context)
    throws IOException, InterruptedException {
    // map() only does computation
    // 1) Run checkpoint per frequency policy.
    // 2) For every vertex on this mapper, run the compute() function
    // 3) Wait until all messaging is done.
    // 4) Check if all vertices are done.  If not goto 2).
    // 5) Dump output.
    if (done) {
      return;
    }
...more code...

just letting everyone know, this might be resolved already?

                
> Simplify boolean expression in GraphMapper::map()
> -------------------------------------------------
>
>                 Key: GIRAPH-132
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-132
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Priority: Trivial
>              Labels: newbie
>
> The boolean expression in:
> {noformat}    @Override
>     public void map(Object key, Object value, Context context)
>         throws IOException, InterruptedException {
>         // map() only does computation
>         // 1) Run checkpoint per frequency policy.
>         // 2) For every vertex on this mapper, run the compute() function
>         // 3) Wait until all messaging is done.
>         // 4) Check if all vertices are done.  If not goto 2).
>         // 5) Dump output.
>         if (done == true) {
>             return;
>         }{noformat}
> can be simplified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message