incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (Updated) (JIRA)" <>
Subject [jira] [Updated] (GIRAPH-40) Adding checkstyle enforcement of Giraph code conventions
Date Wed, 15 Feb 2012 20:31:00 GMT


Avery Ching updated GIRAPH-40:

    Attachment: GIRAPH-40.3.patch

Good suggestion, Jakob.  I have addressed Jakob's comments by changing phases from 'compile'->'verify'
for checkstyle.  This is the only change I made.  

-            <phase>compile</phase>
+            <phase>verify</phase>

We need to require our users to have tested with 'mvn verify' (or 'mvn install') before submitting
diffs.  This matches the rat approach.
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>                 Key: GIRAPH-40
>                 URL:
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>            Priority: Minor
>         Attachments: GIRAPH-40.2.patch, GIRAPH-40.3.patch, GIRAPH-40.patch, GIRAPH-40.patch
> Now that we have some code conventions (see GIRAPH-21), we should enforce them with a
maven checkstyle plugin.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message