incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-144) GiraphJob should not extend Job (users should not be able to call Job methods like waitForCompletion or setMapper..etc)
Date Thu, 09 Feb 2012 09:13:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204378#comment-13204378
] 

jiraposter@reviews.apache.org commented on GIRAPH-144:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3823/
-----------------------------------------------------------

Review request for giraph.


Summary
-------

GiraphJob uses composition with Job instead of extending Job (exposing all Job methods to
users is bad).


This addresses bug GIRAPH-144.
    https://issues.apache.org/jira/browse/GIRAPH-144


Diffs
-----

  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
1241611 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/BspCase.java
1241611 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java
1241611 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
1241611 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
1241611 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
1241611 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
1241611 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
1241611 

Diff: https://reviews.apache.org/r/3823/diff


Testing
-------

local and MR unittests.


Thanks,

Avery


                
> GiraphJob should not extend Job  (users should not be able to call Job methods like waitForCompletion
or setMapper..etc)
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-144
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-144
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Dave
>            Assignee: Avery Ching
>         Attachments: GIRAPH-144.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message