Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: giraph-dev@incubator.apache.org
Date: Wed, 18 Jan 2012 18:06:39 +0000 (UTC)
From: "Jakob Homan (Commented) (JIRA)" <jira@apache.org>
To: giraph-dev@incubator.apache.org
Message-ID: 
 <385059217.53288.1326909999872.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1667670385.53266.1326909641449.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (GIRAPH-126) Use Collections.emptyList() in
 BasicRPCCommunications.java
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/GIRAPH-126?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1318=
8572#comment-13188572 ]=20

Jakob Homan commented on GIRAPH-126:
------------------------------------

Looks good except for the introduction of two new empty lines.  Andre, can =
you remove these and upload a new patch?  I'll commit that.  Thanks.
               =20
> Use Collections.emptyList() in BasicRPCCommunications.java
> ----------------------------------------------------------
>
>                 Key: GIRAPH-126
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-126
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Andr=C3=A9 Kelpe
>            Priority: Minor
>         Attachments: GIRAPH-126.patch
>
>
> I am doing some tests with giraph and I am having some memory problems. W=
hile I was browsing through the codebase I saw that you are allocating a ne=
w ArrayList (which has an underlying array of 10 elements) for each Vertex,=
 that has no Messages to be delivered. That's a waste of memory and time. T=
his patch replaces it with the EMPTY_LIST of the Collections utility class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira