Return-Path: X-Original-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6826D96CA for ; Sat, 28 Jan 2012 01:15:27 +0000 (UTC) Received: (qmail 58128 invoked by uid 500); 28 Jan 2012 01:15:27 -0000 Delivered-To: apmail-incubator-giraph-dev-archive@incubator.apache.org Received: (qmail 58053 invoked by uid 500); 28 Jan 2012 01:15:26 -0000 Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: giraph-dev@incubator.apache.org Delivered-To: mailing list giraph-dev@incubator.apache.org Received: (qmail 58039 invoked by uid 99); 28 Jan 2012 01:15:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Jan 2012 01:15:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2ED091C326A; Sat, 28 Jan 2012 01:15:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5720932218607135414==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-128: RPC port from BasicRPCCommunications should be only a starting port, and retried From: "Avery Ching" To: "Avery Ching" , "giraph" Date: Sat, 28 Jan 2012 01:15:26 -0000 Message-ID: <20120128011526.8384.85879@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3596/ In-Reply-To: <20120124215306.8329.7108@reviews.apache.org> References: <20120124215306.8329.7108@reviews.apache.org> --===============5720932218607135414== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3596/ ----------------------------------------------------------- (Updated 2012-01-28 01:15:26.114994) Review request for giraph. Changes ------- Removed whitspace changes for MinimumIntCombiner.java and SimpleSumCombiner= .java and made GiraphJob.MAX_RPC_PORT_BIND_ATTEMPTS configurable, but defau= lt to 20. Summary ------- Simple handling of port collisions on the same machine while preserving deb= ugability from the port number alone. Round up the max number of workers t= o the next power of 10 and use it as a constant to increase the port number= with. Added a unit test to ensure it is working correctly. Fixed 2 minor warnings on src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java of removing 'import java.util.List'. This addresses bug GIRAPH-128. https://issues.apache.org/jira/browse/GIRAPH-128 Diffs (updated) ----- http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/= apache/giraph/comm/BasicRPCCommunications.java 1236935 = http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/= apache/giraph/graph/GiraphJob.java 1236935 = http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/= apache/giraph/comm/RPCCommunicationsTest.java PRE-CREATION = Diff: https://reviews.apache.org/r/3596/diff Testing ------- Passed local and MR unittests. Thanks, Avery --===============5720932218607135414==--