incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jakob Homan <jgho...@gmail.com>
Subject Re: [jira] [Commented] (GIRAPH-119) VertexCombiner should work on Iterable<M> instead of List<M>
Date Fri, 06 Jan 2012 19:14:32 GMT
Maybe if changelog got modified (unlikely, I know).  Doesn't hurt
anything.  Also, for non-committer contributors, they shouldn't modify
the log since they don't know who may commit their code (ie bob via
joe)

On Fri, Jan 6, 2012 at 11:07 AM, Claudio Martella
<claudio.martella@gmail.com> wrote:
> Ok, I didn't know. I usually do it as it requires 0-knowledge by a second hand.
>
> Btw, why would it conflict?
>
> On Fri, Jan 6, 2012 at 8:05 PM, Jakob Homan (Commented) (JIRA)
> <jira@apache.org> wrote:
>>
>>    [ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181522#comment-13181522
]
>>
>> Jakob Homan commented on GIRAPH-119:
>> ------------------------------------
>>
>> +1.  The change log isn't usually modified as part of the patch, but as part of
the commit, although I don't see a reason it would hurt, except perhaps conflicts in the file?
>>
>>> VertexCombiner should work on Iterable<M> instead of List<M>
>>> ------------------------------------------------------------
>>>
>>>                 Key: GIRAPH-119
>>>                 URL: https://issues.apache.org/jira/browse/GIRAPH-119
>>>             Project: Giraph
>>>          Issue Type: Improvement
>>>          Components: graph
>>>    Affects Versions: 0.70.0
>>>            Reporter: Claudio Martella
>>>            Assignee: Claudio Martella
>>>         Attachments: GIRAPH-119.diff
>>>
>>>
>>> Currently VertexCombiner expects a List<M>. It should be refactored to
Iterable<M> to sync with Iterable-based BasicVertex messages logics.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>
>
>
> --
>    Claudio Martella
>    claudio.martella@gmail.com

Mime
View raw message