incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-116) Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.
Date Mon, 02 Jan 2012 19:06:30 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178514#comment-13178514
] 

Hudson commented on GIRAPH-116:
-------------------------------

Integrated in Giraph-trunk-Commit #60 (See [https://builds.apache.org/job/Giraph-trunk-Commit/60/])
    GIRAPH-116. Forgot to remove this.
GIRAPH-116: Make EdgeListVertex the default vertex implementation, fix
bugs related to EdgeListVertex. (aching)

aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226518
Files : 
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java

aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226513
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/WorkerCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCombinerVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleFailVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMsgVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/VerifyMessage.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/HashMapVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/IntIntNullIntVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MutableVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexResolver.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/Partition.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexTypes.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleShortestPathVertexTest.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/utils/MockUtils.java

                
> Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.
> ------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-116
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-116
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-116.patch
>
>
> I think this would best for new users as it is much more memory efficient than Vertex
with respect to edges (list vs hash map).  We seem to be mostly iterating over the edges (as
several others had pointed out in earlier JIRAs and emails), so this would provide early users
with a more memory efficient implementation without performance loss.  If anyone disagrees,
please voice your opinions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message