incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Martella (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-118) Clarify messages behavior in BasicVertex
Date Fri, 06 Jan 2012 14:05:40 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Claudio Martella updated GIRAPH-118:
------------------------------------

          Description: 
initialize() can receive a null parameter for messages (at least that's what EdgeListVertex
does). We should avoid that and pass an empty Iterable instead. That should be cheap for us
inside of the InputFormat, just passing a static immutable empty list.

setMessages(Iterable<M>) should be changed to putMessages(Iterable<M>). the set
prefix suggests an assignment, while setMessages is used to transfer the messages to the internal
datastructure the user is responsible for. putMessages() should clarify this.
    Affects Version/s: 0.70.0
             Assignee: Claudio Martella
    
> Clarify messages behavior in BasicVertex
> ----------------------------------------
>
>                 Key: GIRAPH-118
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-118
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Minor
>
> initialize() can receive a null parameter for messages (at least that's what EdgeListVertex
does). We should avoid that and pass an empty Iterable instead. That should be cheap for us
inside of the InputFormat, just passing a static immutable empty list.
> setMessages(Iterable<M>) should be changed to putMessages(Iterable<M>). the
set prefix suggests an assignment, while setMessages is used to transfer the messages to the
internal datastructure the user is responsible for. putMessages() should clarify this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message