incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (Commented) (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-126) Use Collections.emptyList() in
Date Wed, 18 Jan 2012 18:06:39 GMT


Jakob Homan commented on GIRAPH-126:

Looks good except for the introduction of two new empty lines.  Andre, can you remove these
and upload a new patch?  I'll commit that.  Thanks.
> Use Collections.emptyList() in
> ----------------------------------------------------------
>                 Key: GIRAPH-126
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: André Kelpe
>            Priority: Minor
>         Attachments: GIRAPH-126.patch
> I am doing some tests with giraph and I am having some memory problems. While I was browsing
through the codebase I saw that you are allocating a new ArrayList (which has an underlying
array of 10 elements) for each Vertex, that has no Messages to be delivered. That's a waste
of memory and time. This patch replaces it with the EMPTY_LIST of the Collections utility

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message