incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: GIRAPH-124: Combiner should return Iterable<M> instead of M or null.
Date Mon, 23 Jan 2012 20:54:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3592/#review4538
-----------------------------------------------------------

Ship it!


Looks great!  One very minor thing.  Before you commit, can you please prefix the exception
messages with "run: "? The other exception messages always start with the method name and
then a colon.  You don't need to resubmit a review, just make those changes and please commit.
 Thanks!


trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
<https://reviews.apache.org/r/3592/#comment10130>

    please prefix with "run: "



trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
<https://reviews.apache.org/r/3592/#comment10133>

    please prefix with "run: "



trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
<https://reviews.apache.org/r/3592/#comment10131>

    please prefix with "run: "



trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
<https://reviews.apache.org/r/3592/#comment10132>

    please prefix with "run: "


- Avery


On 2012-01-23 20:38:48, Claudio Martella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3592/
> -----------------------------------------------------------
> 
> (Updated 2012-01-23 20:38:48)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> -------
> 
> Fixed the null check on the returned value and the javadoc..
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1234376 
>   trunk/src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java 1234376 
>   trunk/src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java 1234376 
>   trunk/src/main/java/org/apache/giraph/graph/VertexCombiner.java 1234376 
>   trunk/src/test/java/org/apache/giraph/TestVertexTypes.java 1234376 
>   trunk/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java 1234376

> 
> Diff: https://reviews.apache.org/r/3592/diff
> 
> 
> Testing
> -------
> 
> local and MR unit tests
> 
> 
> Thanks,
> 
> Claudio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message