incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Kelpe (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-126) Use Collections.emptyList() in BasicRPCCommunications.java
Date Wed, 18 Jan 2012 19:34:39 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188654#comment-13188654
] 

André Kelpe commented on GIRAPH-126:
------------------------------------

@Claudio True. One question though: When I read EdgeListVertex I see that it creates new instances
via the Lists utility class from guava while in in the BasicRPCCommunications the ArrayList
constructor is used directly. What is the preferred way in giraph?
                
> Use Collections.emptyList() in BasicRPCCommunications.java
> ----------------------------------------------------------
>
>                 Key: GIRAPH-126
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-126
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: André Kelpe
>            Assignee: André Kelpe
>            Priority: Minor
>         Attachments: GIRAPH-126.patch, GIRAPH-126.patch, GIRAPH-126.patch
>
>
> I am doing some tests with giraph and I am having some memory problems. While I was browsing
through the codebase I saw that you are allocating a new ArrayList (which has an underlying
array of 10 elements) for each Vertex, that has no Messages to be delivered. That's a waste
of memory and time. This patch replaces it with the EMPTY_LIST of the Collections utility
class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message