incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (Commented) (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-126) Use Collections.emptyList() in
Date Wed, 18 Jan 2012 18:48:40 GMT


Jakob Homan commented on GIRAPH-126:

yeah, good catch:
{noformat}scala> list3.add(42)
        at java.util.AbstractList.add(
        at java.util.AbstractList.add(
        at .<init>(<console>:7)
        at .<clinit>(<console>)
        at RequestResult$.<init>(<console>:9)
        at RequestResult$.<clinit>(<console>)
        at RequestResult$scala_repl_result(<console>)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(
        at java.lang.reflect.Method.invoke(
> Use Collections.emptyList() in
> ----------------------------------------------------------
>                 Key: GIRAPH-126
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: André Kelpe
>            Assignee: André Kelpe
>            Priority: Minor
>         Attachments: GIRAPH-126.patch, GIRAPH-126.patch, GIRAPH-126.patch
> I am doing some tests with giraph and I am having some memory problems. While I was browsing
through the codebase I saw that you are allocating a new ArrayList (which has an underlying
array of 10 elements) for each Vertex, that has no Messages to be delivered. That's a waste
of memory and time. This patch replaces it with the EMPTY_LIST of the Collections utility

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message