Return-Path: 
 <giraph-dev-return-1209-apmail-incubator-giraph-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 75D0A7969
	for <apmail-incubator-giraph-dev-archive@minotaur.apache.org>;
 Mon, 19 Dec 2011 14:50:59 +0000 (UTC)
Received: (qmail 98382 invoked by uid 500); 19 Dec 2011 14:50:59 -0000
Delivered-To: apmail-incubator-giraph-dev-archive@incubator.apache.org
Received: (qmail 98352 invoked by uid 500); 19 Dec 2011 14:50:58 -0000
Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:giraph-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:giraph-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:giraph-dev@incubator.apache.org>
List-Id: <giraph-dev.incubator.apache.org>
Reply-To: giraph-dev@incubator.apache.org
Delivered-To: mailing list giraph-dev@incubator.apache.org
Received: (qmail 98337 invoked by uid 99); 19 Dec 2011 14:50:58 -0000
Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Dec 2011 14:50:58 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 7910D1C27DE;
	Mon, 19 Dec 2011 14:50:58 +0000 (UTC)
Content-Type: multipart/alternative;
	boundary="===============4337374205034299474=="
MIME-Version: 1.0
Subject: Re: Review Request: GIRAPH-106: Change prepareSuperstep() to make
 setMessages(Iterable<M> messages) package-private
From: "Claudio Martella" <claudio.martella@gmail.com>
To: "Avery Ching" <avery.ching@gmail.com>,
	"giraph" <giraph-dev@incubator.apache.org>,
	"Claudio Martella" <claudio.martella@gmail.com>
Date: Mon, 19 Dec 2011 14:50:58 -0000
Message-ID: <20111219145058.1031.37722@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
X-ReviewRequest-URL: https://reviews.apache.org/r/3255/
In-Reply-To: <20111219082555.23236.15863@reviews.apache.org>
References: <20111219082555.23236.15863@reviews.apache.org>

--===============4337374205034299474==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3255/#review3971
-----------------------------------------------------------

Ship it!


Very simple, good work. +1

- Claudio


On 2011-12-19 08:25:55, Avery Ching wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3255/
> -----------------------------------------------------------
> =

> (Updated 2011-12-19 08:25:55)
> =

> =

> Review request for giraph.
> =

> =

> Summary
> -------
> =

> Added method assignMessagesToVertex() to bypass the package-private acces=
s for setMessages().  Cleaned up some missed formatting for GIRAPH-80 as we=
ll.
> =

> =

> This addresses bug GIRAPH-106.
>     https://issues.apache.org/jira/browse/GIRAPH-106
> =

> =

> Diffs
> -----
> =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/bsp/CentralizedServiceWorker.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/comm/BasicRPCCommunications.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/comm/CommunicationsInterface.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/graph/BasicVertex.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/graph/BasicVertexResolver.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/graph/BspServiceWorker.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/graph/EdgeListVertex.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/graph/LongDoubleFloatDoubleVertex.java 1220642 =

>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/or=
g/apache/giraph/graph/Vertex.java 1220642 =

> =

> Diff: https://reviews.apache.org/r/3255/diff
> =

> =

> Testing
> -------
> =

> Passed local unittests.
> =

> =

> Thanks,
> =

> Avery
> =

>


--===============4337374205034299474==--