incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Schelter (Commented) (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-73) A little refactoring
Date Sun, 18 Dec 2011 10:32:30 GMT


Sebastian Schelter commented on GIRAPH-73:

You are right. 

The problem is that if there is an exception thrown in the try { ... } block and another exception
is thrown in the finally { ... } block, than you only get to see the second one. That's why
people usually choose to swallow and only log the exceptions arising from close. 

Should I rework the patch to ensure the job will be failed in case there are exceptions in

Here are some details about stream handling in java (it's a mess...)
> A little refactoring
> --------------------
>                 Key: GIRAPH-73
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.70.0
>            Reporter: Sebastian Schelter
>            Priority: Minor
>         Attachments: GIRAPH-73-2.patch, GIRAPH-73.patch
> Hi, I'm currently reading Giraph's sources and starting to play with it. I fixed some
small things along the way (like making sure writers are closed, exceptions are logged, etc.),
thought that maybe helpful.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message