incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Review Request: GIRAPH-112: Use elements() properly in LongDoubleFloatDoubleVertex
Date Wed, 21 Dec 2011 07:50:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3287/
-----------------------------------------------------------

Review request for giraph.


Summary
-------

As pointed out by YuanYua, the array returned by elements() cannot have its length used since
the array contains all the elements currently stored in the mahout collections, even including
invalid elements between size and capacity.

Whenever possible I converted elements() into forEach(), forEachKey(), forEachPair().  Used
size() in other cases.

Fixed some formatting violations as well in LongDoubleFloatDoubleVertex.java.


This addresses bug GIRAPH-112.
    https://issues.apache.org/jira/browse/GIRAPH-112


Diffs
-----

  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
1221634 

Diff: https://reviews.apache.org/r/3287/diff


Testing
-------

Local unittests and MR unittests.


Thanks,

Avery


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message