incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Martella" <claudio.marte...@gmail.com>
Subject Re: Review Request: GIRAPH-106: Change prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
Date Mon, 19 Dec 2011 14:50:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3255/#review3971
-----------------------------------------------------------

Ship it!


Very simple, good work. +1

- Claudio


On 2011-12-19 08:25:55, Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3255/
> -----------------------------------------------------------
> 
> (Updated 2011-12-19 08:25:55)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> -------
> 
> Added method assignMessagesToVertex() to bypass the package-private access for setMessages().
 Cleaned up some missed formatting for GIRAPH-80 as well.
> 
> 
> This addresses bug GIRAPH-106.
>     https://issues.apache.org/jira/browse/GIRAPH-106
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
1220642 
>   http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
1220642 
> 
> Diff: https://reviews.apache.org/r/3255/diff
> 
> 
> Testing
> -------
> 
> Passed local unittests.
> 
> 
> Thanks,
> 
> Avery
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message