incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-73) A little refactoring
Date Sun, 18 Dec 2011 08:28:31 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171797#comment-13171797
] 

Avery Ching commented on GIRAPH-73:
-----------------------------------

Most of these changes look good, but I'm not sure I agree with the use of Closeables.closeQuietly()
in ZooKeeperManager.java since if we do get an IOException I think we'd want the program to
die as soon as possible.

                
> A little refactoring
> --------------------
>
>                 Key: GIRAPH-73
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-73
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.70.0
>            Reporter: Sebastian Schelter
>            Priority: Minor
>         Attachments: GIRAPH-73-2.patch, GIRAPH-73.patch
>
>
> Hi, I'm currently reading Giraph's sources and starting to play with it. I fixed some
small things along the way (like making sure writers are closed, exceptions are logged, etc.),
thought that maybe helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message