Return-Path: 
 <giraph-dev-return-677-apmail-incubator-giraph-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 52E6F751D
	for <apmail-incubator-giraph-dev-archive@minotaur.apache.org>;
 Tue,  1 Nov 2011 20:37:58 +0000 (UTC)
Received: (qmail 84919 invoked by uid 500); 1 Nov 2011 20:37:57 -0000
Delivered-To: apmail-incubator-giraph-dev-archive@incubator.apache.org
Received: (qmail 84870 invoked by uid 500); 1 Nov 2011 20:37:57 -0000
Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:giraph-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:giraph-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:giraph-dev@incubator.apache.org>
List-Id: <giraph-dev.incubator.apache.org>
Reply-To: giraph-dev@incubator.apache.org
Delivered-To: mailing list giraph-dev@incubator.apache.org
Received: (qmail 84732 invoked by uid 99); 1 Nov 2011 20:37:57 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Nov 2011 20:37:57 +0000
X-ASF-Spam-Status: No, hits=-2001.2 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Nov 2011 20:37:55 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 65D7832D9FD
	for <giraph-dev@incubator.apache.org>; Tue,  1 Nov 2011 20:37:34 +0000 (UTC)
Date: Tue, 1 Nov 2011 20:37:34 +0000 (UTC)
From: "Jake Mannix (Commented) (JIRA)" <jira@apache.org>
To: giraph-dev@incubator.apache.org
Message-ID: 
 <691298873.47352.1320179854418.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <926685023.36872.1316214069680.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex
 is possible by user apps
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141553#comment-13141553 ] 

Jake Mannix commented on GIRAPH-36:
-----------------------------------

Ok, got the setGraphState() stuff out, tests pass, with a little messing around.

So formatting:  I tracked down all of the stray "if(" bits, but do you know of any easy way to find files which have mixed spacing?  I couldn't think of a good regex? :P

Also, regarding committing: I never heard back from you or Owen about getting myself actually getting commit privileges.  I never heard from infra@, etc.
                
> Ensure that subclassing BasicVertex is possible by user apps
> ------------------------------------------------------------
>
>                 Key: GIRAPH-36
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-36
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>            Priority: Blocker
>             Fix For: 0.70.0
>
>         Attachments: GIRAPH-36.diff
>
>
> Original assumptions in Giraph were that all users would subclass Vertex (which extended MutableVertex extended BasicVertex).  Classes which wish to have application specific data structures (ie. not a TreeMap<I, Edge<I,E>>) may need to extend either MutableVertex or BasicVertex.  Unfortunately VertexRange extends ArrayList<Vertex>, and there are other places where the assumption is that vertex classes are either Vertex, or at least MutableVertex.
> Let's make sure the internal APIs allow for BasicVertex to be the base class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira