Return-Path: X-Original-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F2C6F9D14 for ; Wed, 16 Nov 2011 21:32:12 +0000 (UTC) Received: (qmail 7665 invoked by uid 500); 16 Nov 2011 21:32:12 -0000 Delivered-To: apmail-incubator-giraph-dev-archive@incubator.apache.org Received: (qmail 7602 invoked by uid 500); 16 Nov 2011 21:32:12 -0000 Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: giraph-dev@incubator.apache.org Delivered-To: mailing list giraph-dev@incubator.apache.org Received: (qmail 7499 invoked by uid 99); 16 Nov 2011 21:32:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Nov 2011 21:32:12 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Nov 2011 21:32:11 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C21C58941C for ; Wed, 16 Nov 2011 21:31:51 +0000 (UTC) Date: Wed, 16 Nov 2011 21:31:51 +0000 (UTC) From: "Jake Mannix (Commented) (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: <363617447.36313.1321479111796.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1315348879.36289.1321478511684.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (GIRAPH-90) LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151532#comment-13151532 ] Jake Mannix commented on GIRAPH-90: ----------------------------------- It's probably not what we want, no. LongWritables are cheap, let's make new ones and return those. > LongDoubleFloatDoubleVertex has possibily the iterator() implementation broken > ------------------------------------------------------------------------------ > > Key: GIRAPH-90 > URL: https://issues.apache.org/jira/browse/GIRAPH-90 > Project: Giraph > Issue Type: Bug > Components: graph > Affects Versions: 0.70.0 > Reporter: Claudio Martella > Assignee: Claudio Martella > Fix For: 0.70.0 > > > iterator() implementation returns LongWritable which is cached in a final variable and set() with the new value at next(). This could be misleading as the user might create a list from the iterator's data. Something similar is happening in the getMsgList() as well. > Is this really what we want? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira