incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gianmarco De Francisci Morales (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
Date Tue, 15 Nov 2011 13:55:51 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150498#comment-13150498
] 

Gianmarco De Francisci Morales commented on GIRAPH-74:
------------------------------------------------------

Just my 2 cents.
Having a field instead of a method is generally a bad thing.
If you want to later change this, you need to break the API.

I personally like the idea to use the return value of compute instead of having a separate
halting procedure, it makes the whole process look more "functional".
                
> GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
> ---------------------------------------------------------------------------
>
>                 Key: GIRAPH-74
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-74
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>             Fix For: 0.70.0
>
>         Attachments: GIRAPH-36-cleaup.diff, GIRAPH-70.diff
>
>
> After GIRAPH-36, in a couple of places Vertex was left instead of BasicVertex. To achieve
the fix a BasicVertex was extended with a new boolean isHalted(boolean state) method that
totally hides boolean halt field. I believe this unifies the voteToHalt() and isHalted() methods
totally hiding the halting management of Vertices (before it was relying on the existence
of boolean halt field).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message