incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shaunak Kashyap (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader
Date Thu, 17 Nov 2011 23:49:51 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152469#comment-13152469
] 

Shaunak Kashyap commented on GIRAPH-84:
---------------------------------------

I believe that style goes against the coding conventions for this project (see http://svn.apache.org/repos/asf/incubator/giraph/trunk/CODE_CONVENTIONS).

I wonder if using the ternary operator like so is acceptable:

{code}
return (seenRecord ? 1f : 0f);
{code}
                
> Simplify boolean expressions in BspRecordReader
> -----------------------------------------------
>
>                 Key: GIRAPH-84
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-84
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Attila Csordas
>              Labels: newbie
>
> Twice in BspRecordReader boolean expressions are evaluated with == and can be simplified
to just one liners or variable evaluation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message