incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Review Request: GIRAPH-91 - Large-memory improvements (Memory reduced vertex implementation, fast failure, added settings)
Date Wed, 16 Nov 2011 22:37:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2868/
-----------------------------------------------------------

Review request for giraph.


Summary
-------

There general changes should support larger heap sizes (i.e. >20G)

- Added new EdgeListVertex that stores its edges in a compact pair of lists instead of Vertex's
HashMap.

- Added unittests TestEdgeArrayVertex to test EdgeListVertex.

- Augmented PageRankBenchmark to choose between EdgeListArrayVertex or Vertex (to try it out).

- Added failure cleanup for failed workers to quickly alert the master that they are dead
by deleting its health ephemeral znode.  This allows us to set higher ZooKeeper timeouts to
deal with GC pauses and the like.  In a quick test of 3 nodes, I saw failure in 43 seconds
instead of 1m 52 sec.

- Added a context.progress() to flushing to not kill jobs with long timeouts (GC or lots of
messages).


This addresses bug GIRAPH-91.
    https://issues.apache.org/jira/browse/GIRAPH-91


Diffs
-----

  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
1202898 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
1202898 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
1202898 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
1202898 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
1202898 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
1202898 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java
1202898 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/2868/diff


Testing
-------

Local unittests, PageRankBenchmark on multiple machines with >20GB heaps.


Thanks,

Avery


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message