incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy Ryaboy" <dvrya...@gmail.com>
Subject Re: Review Request: GIRAPH-64
Date Sat, 12 Nov 2011 02:15:53 GMT


> On 2011-11-03 05:32:49, Jake Mannix wrote:
> > It would be super cool if, like in Mahout and Hadoop, we could print out the set
of Vertex impls / algorithms / actions available.  In Mahout, we have a properties file which
we keep updating.  Even nicer (maybe?) would be to just search the classpath for all classes
which implement BasicVertex, and list them.  Even cooler: have a new abstract method on BasicVertex
"String getHelp()" which GiraphRunner could run via reflection to get the help output for
the task.
> 
> Jakob Homan wrote:
>     Absolutely. Another JIRA?

abstract method or annotation? 

Nice thing about annotations is that you can hook into them during compilation and produce
docs...


- Dmitriy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/#review3023
-----------------------------------------------------------


On 2011-11-12 02:03:20, Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2700/
> -----------------------------------------------------------
> 
> (Updated 2011-11-12 02:03:20)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> -------
> 
> create giraphrunner
> 
> 
> This addresses bug GIRAPH-64.
>     https://issues.apache.org/jira/browse/GIRAPH-64
> 
> 
> Diffs
> -----
> 
>   /trunk/bin/giraph PRE-CREATION 
>   /trunk/pom.xml 1196926 
>   /trunk/src/main/assembly/assembly.xml PRE-CREATION 
>   /trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION 
>   /trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926 
> 
> Diff: https://reviews.apache.org/r/2700/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jakob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message