incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Martella (Commented) (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-60) Export BspService public get*Path() methods through static
Date Fri, 21 Oct 2011 17:42:32 GMT


Claudio Martella commented on GIRAPH-60:

As I'm implementing AggregatorsWriter, I realized I'd need to access getMergedAggregatorPath()
to get the aggregated values to dump to disk. I wanted to avoid passing BspService to the
implementation to hide it from the user.

At second thought, as I can see that it's not so trivial (APPLICATION_ATTEMPTS_PATH is not
a constant), I thought to make AggregatorsWriter an abstract class where we would have a setBspService()
called by us at instantiation (a bit like what happens now with GraphState somewhere else)
and a final JsonObject getMergedValues() method that would return directly the aggregated
values to the user. This would allow us to hide BspService and all the machine under the hood
and provide the user the merged values ready to write. I'll work on this idea. What do you
> Export BspService public get*Path() methods through static
> ----------------------------------------------------------
>                 Key: GIRAPH-60
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Trivial
>             Fix For: 0.70.0
> BspService has methods to compose Paths such as getSuperstepPath() etc. that could be
used by other non-implementing classes. We should export them through static.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message