incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Mannix (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored
Date Fri, 09 Sep 2011 03:49:08 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100939#comment-13100939
] 

Jake Mannix commented on GIRAPH-27:
-----------------------------------

I'm down with not exposing GraphState to the users, but I'm concerned with basically requiring
that users be subclasses of Vertex, and are not allowed to implement BasicVertex themselves,
because if they did so, the framework would try to instantiate them as subclasses of Vertex,
and fail with runtime exceptions (this is what happened to me in trying to make a primitive-specific
alternative to Vertex, while keeping the API fixed).

> Mutable static global state in Vertex.java should be refactored
> ---------------------------------------------------------------
>
>                 Key: GIRAPH-27
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-27
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>         Attachments: GIRAPH-27.patch, GIRAPH-27.patch
>
>
> Vertex.java has a bunch of static methods for getting/setting global graph state (total
number of vertices, edges, a reference to the GraphMapper, etc).  Refactoring this into a
GraphState object, which every Vertex can hold onto a reference to (yes, a tiny bit more memory
per Vertex, but in comparison to what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message