incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored
Date Thu, 08 Sep 2011 19:26:08 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100616#comment-13100616
] 

Dmitriy V. Ryaboy commented on GIRAPH-27:
-----------------------------------------

I took a brief look; it'd be great if we agreed on import ordering so that everyone's IDEs
didn't reorder every time.

You do have some two-space padding in places; I believe Giraph conventions are 4 spaces.

public class GraphState needs a javadoc (what are I, V, E, and M? I know, but it'd be nice
to have it in writing..) Said javadoc should probably include scary warnings about making
sure that one doesn't wind up with multiple different states floating around in a job.


Can you make the GraphState setters chainable (return this instead of void)? That'll make
creating them flow much nicer in GraphMapper.


Why remove the \<I\>, etc in calls to BspUtils methods in Vertex?



> Mutable static global state in Vertex.java should be refactored
> ---------------------------------------------------------------
>
>                 Key: GIRAPH-27
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-27
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>         Attachments: GIRAPH-27.patch
>
>
> Vertex.java has a bunch of static methods for getting/setting global graph state (total
number of vertices, edges, a reference to the GraphMapper, etc).  Refactoring this into a
GraphState object, which every Vertex can hold onto a reference to (yes, a tiny bit more memory
per Vertex, but in comparison to what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message