incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored
Date Fri, 09 Sep 2011 04:45:16 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100970#comment-13100970
] 

jiraposter@reviews.apache.org commented on GIRAPH-27:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1771/
-----------------------------------------------------------

(Updated 2011-09-09 04:44:32.531014)


Review request for giraph.


Changes
-------

Make BasicVertex and MutableVertex abstract classes.  BasicVertex has package private methods
for get/setGraphState().


Summary
-------

Based on Jake's submission https://issues.apache.org/jira/secure/attachment/12493654/GIRAPH-27.patch
Couple of small changes:
- Do not expose GraphState to application developers
- Fixing a few formatting issues


This addresses bug GIRAPH-27.
    https://issues.apache.org/jira /browse/GIRAPH-27


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphState.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MutableVertex.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexRange.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexResolver.java
1166925 
  http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
1166925 

Diff: https://reviews.apache.org/r/1771/diff


Testing
-------

Unittest and page rank benchmark on Yahoo! grid with 10 workers.


Thanks,

Avery



> Mutable static global state in Vertex.java should be refactored
> ---------------------------------------------------------------
>
>                 Key: GIRAPH-27
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-27
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>         Attachments: GIRAPH-27.patch, GIRAPH-27.patch
>
>
> Vertex.java has a bunch of static methods for getting/setting global graph state (total
number of vertices, edges, a reference to the GraphMapper, etc).  Refactoring this into a
GraphState object, which every Vertex can hold onto a reference to (yes, a tiny bit more memory
per Vertex, but in comparison to what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message