incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Mannix (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored
Date Thu, 08 Sep 2011 19:52:08 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100639#comment-13100639
] 

Jake Mannix commented on GIRAPH-27:
-----------------------------------

4-space padding, but I code on a laptop! :(  yeah, I guess I can fix that.  Import ordering...
oof.  Imports should be a Set, not a List...

Javadocs sound good, and agreed on the scariness about moving state to a bean, which could
possibly be instantiated multiple times, and nobody knows who's got what... either that, the
static factory method (not avoiding statics there), or the elusive RecursiveReflectionFactoriesAllTheWayDownFactory.

Chainable setters sounds like a good call.

Removed the types in BspUtils because the type could be inferred, wasn't necessary.

> Mutable static global state in Vertex.java should be refactored
> ---------------------------------------------------------------
>
>                 Key: GIRAPH-27
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-27
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>         Attachments: GIRAPH-27.patch
>
>
> Vertex.java has a bunch of static methods for getting/setting global graph state (total
number of vertices, edges, a reference to the GraphMapper, etc).  Refactoring this into a
GraphState object, which every Vertex can hold onto a reference to (yes, a tiny bit more memory
per Vertex, but in comparison to what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message