incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-31) Hide the SortedMap<I, Edge<I,E>> in Vertex from client visibility (impl. detail), replace with appropriate accessor methods
Date Wed, 14 Sep 2011 14:36:10 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104527#comment-13104527
] 

Hudson commented on GIRAPH-31:
------------------------------

Integrated in Giraph-trunk-Commit #5 (See [https://builds.apache.org/job/Giraph-trunk-Commit/5/])
    GIRAPH-31: Hide the SortedMap<I, Edge<I,E>> in Vertex from client
visibility (impl. detail), replace with appropriate accessor
methods. jake.mannix via aching.

aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170431
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleFailVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MutableVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexRange.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexResolver.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexInputFormat.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexOutputFormat.java


> Hide the SortedMap<I, Edge<I,E>> in Vertex from client visibility (impl.
detail), replace with appropriate accessor methods
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-31
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-31
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>         Attachments: GIRAPH-31.diff, GIRAPH-31.diff
>
>
> As discussed on the list, and on GIRAPH-28, the SortedMap<I, Edge<I,E>> is
an implementation detail which needs not be exposed to application developers - they need
to iterate over the edges, and possibly access them one-by-one, and remove them (in the Mutable
case), but they don't need the SortedMap, and creating primitive-optimized BasicVertex implementations
is hampered by the fact that clients expect this Map to exist.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message