incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Mannix (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-31) Hide the SortedMap<I, Edge<I,E>> in Vertex from client visibility (impl. detail), replace with appropriate accessor methods
Date Tue, 13 Sep 2011 16:29:09 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103734#comment-13103734
] 

Jake Mannix commented on GIRAPH-31:
-----------------------------------

Avery, Dmitriy - after thinking about it, I think both true and false are wrong!  BasicVertex
shouldn't implement this method at all, leave it abstract, and sublcasses which implement
iterator() are forced to also tell users whether it chose to implement it sorted or not. 


> Hide the SortedMap<I, Edge<I,E>> in Vertex from client visibility (impl.
detail), replace with appropriate accessor methods
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-31
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-31
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>         Attachments: GIRAPH-31.diff
>
>
> As discussed on the list, and on GIRAPH-28, the SortedMap<I, Edge<I,E>> is
an implementation detail which needs not be exposed to application developers - they need
to iterate over the edges, and possibly access them one-by-one, and remove them (in the Mutable
case), but they don't need the SortedMap, and creating primitive-optimized BasicVertex implementations
is hampered by the fact that clients expect this Map to exist.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message