Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: giraph-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: 216.145.54.173 is neither permitted
 nor denied by domain of aching@yahoo-inc.com)
From: Avery Ching <aching@yahoo-inc.com>
To: "giraph-dev@incubator.apache.org" <giraph-dev@incubator.apache.org>
Date: Tue, 30 Aug 2011 11:54:26 -0700
Subject: Re: Reviewboard for code reviews
Thread-Topic: Reviewboard for code reviews
Thread-Index: AcxnRj3O5Cn31sCMSgO3KJDBhHLqUA==
Message-ID: <E6DCDF85-4334-45FD-812E-C479207FE258@yahoo-inc.com>
References: <B0202B6F-5EA7-42F7-A1FC-2D7682529612@yahoo-inc.com>
 <CAM=XDd_WhKfATRKzNYbXEZ1N9Sr63qecz2-EM7sWrYdPvR1viQ@mail.gmail.com>
 <A6A03D20-A2F4-4255-82B3-B4BE70985530@yahoo-inc.com>
 <CALuGr6YNKohFi7b01CTUtRiyLebZELDFL2ihRC4L0DoM-Paw2A@mail.gmail.com>
 <F3B3C14F-54A8-4754-BC8B-0CEBAF7FA51F@yahoo-inc.com>
 <CADiKvVsDWSxh3L99SJqseBz=h8STOHBLw7ZDMPdoqDs8BfmEaA@mail.gmail.com>
 <CALuGr6YdNYLCR807p6H8yKAHxOObdz24Y3xHh6r=wTtJjc2jgg@mail.gmail.com>
 <CALuGr6aXWvzU1JMiKjb=uu3nRzc6XRLAYtAxAYPRKpRY2U91Xw@mail.gmail.com>
In-Reply-To: 
 <CALuGr6aXWvzU1JMiKjb=uu3nRzc6XRLAYtAxAYPRKpRY2U91Xw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Okay, let's make it optional for now.  For me, it definitely helps to visua=
lize the changes better.  Also, I think the feedback tool is pretty good.

Avery

On Aug 30, 2011, at 11:52 AM, Henry Saputra wrote:

> Argh I meant "It should just an option to help review and should not
> be required for patches."
>=20
> - Henry
>=20
> On Tue, Aug 30, 2011 at 11:51 AM, Henry Saputra <henry.saputra@gmail.com>=
 wrote:
>> +1
>>=20
>> It should just optional to help review not required.
>>=20
>> - Henry
>>=20
>> On Tue, Aug 30, 2011 at 11:48 AM, Jakob Homan <jghoman@gmail.com> wrote:
>>> We've just gone around on this one for Kafka and, if reviewboard is
>>> provided, it would be good to keep it as an optional part of the
>>> process.  I've had very negative experiences with it, both in Hadoop
>>> and Hive.  If one would like to do a reviewboard review, that's great
>>> - but for those who don't, standard bullet points should suffice.
>>> -jakob
>>>=20
>>>=20
>>>=20
>>> On Tue, Aug 30, 2011 at 11:38 AM, Avery Ching <aching@yahoo-inc.com> wr=
ote:
>>>> Thanks Henry.  I have filed issue
>>>>=20
>>>> https://issues.apache.org/jira/browse/INFRA-3892
>>>>=20
>>>> to get reviewboard access.
>>>>=20
>>>> Avery
>>>>=20
>>>> On Aug 30, 2011, at 11:35 AM, Henry Saputra wrote:
>>>>=20
>>>> Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in
>>>> reviews board.
>>>>=20
>>>> I filed tickets to create one for Kafka and Gora.
>>>>=20
>>>> - Henry
>>>>=20
>>>> On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching <aching@yahoo-inc.com<ma=
ilto:aching@yahoo-inc.com>> wrote:
>>>> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_t=
he
>>>>=20
>>>> I'll file an INFRA ticket.
>>>>=20
>>>> Thanks,
>>>>=20
>>>> Avery
>>>>=20
>>>> On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
>>>>=20
>>>> Looks possible. Some incubator project (e.g., Kafka) already has a
>>>> reviewboard group.
>>>>=20
>>>> Best regards,
>>>> --
>>>> Hyunsik Choi
>>>>=20
>>>>=20
>>>>=20
>>>> On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <aching@yahoo-inc.com<mai=
lto:aching@yahoo-inc.com>> wrote:
>>>> Anyone know if we have reviewboard access?
>>>>=20
>>>> Thanks,
>>>>=20
>>>> Avery
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>=20
>>=20