Return-Path: 
 <giraph-dev-return-137-apmail-incubator-giraph-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-giraph-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D9A2C735B
	for <apmail-incubator-giraph-dev-archive@minotaur.apache.org>;
 Wed, 31 Aug 2011 16:57:31 +0000 (UTC)
Received: (qmail 63990 invoked by uid 500); 31 Aug 2011 16:57:31 -0000
Delivered-To: apmail-incubator-giraph-dev-archive@incubator.apache.org
Received: (qmail 63969 invoked by uid 500); 31 Aug 2011 16:57:31 -0000
Mailing-List: contact giraph-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:giraph-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:giraph-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:giraph-dev@incubator.apache.org>
List-Id: <giraph-dev.incubator.apache.org>
Reply-To: giraph-dev@incubator.apache.org
Delivered-To: mailing list giraph-dev@incubator.apache.org
Received: (qmail 63941 invoked by uid 99); 31 Aug 2011 16:57:31 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2011 16:57:31 +0000
X-ASF-Spam-Status: No, hits=-2000.5 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Aug 2011 16:57:30 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 5BDB6439AA
	for <giraph-dev@incubator.apache.org>; Wed, 31 Aug 2011 16:57:10 +0000 (UTC)
Date: Wed, 31 Aug 2011 16:57:10 +0000 (UTC)
From: "Avery Ching (JIRA)" <jira@apache.org>
To: giraph-dev@incubator.apache.org
Message-ID: 
 <294301186.3353.1314809830372.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <459754261.1184.1314759189948.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (GIRAPH-18) Refactor
 BspServiceWorker::loadVertices()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/GIRAPH-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094686#comment-13094686 ] 

Avery Ching commented on GIRAPH-18:
-----------------------------------

+1

Nice work refactoring, makes the code more readable.  Sorry it took me so long to review, but it's tougher for me without my trusty reviewboard =).  I was able to pass the unittests with your changes.

I also like your change to save some memory (every bit helps).  

Couple of style notes:

We have a CODE_CONVENTIONS file in the base path, probably this should be updated?  I'll file a separate JIRA for this.

1.  Map<I,List<Long>> ->  Map<I, List<Long>>
2.  Current style is limitted to 80 chars per line (or should be).  Maybe this is unrealistic?
3.  Some 2 style indentation, i.e.

	while ((inputSplitPath = reserveInputSplit()) != null) {
          Map<I,List<Long>> maxIndexStatMap =


> Refactor BspServiceWorker::loadVertices()
> -----------------------------------------
>
>                 Key: GIRAPH-18
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-18
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-18.patch
>
>
> Currently BspServiceWorker::loadVertices() is more than 200 lines and convoluted. I found it difficult to grok while debugging today.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira