incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-17) Giraph doesn't give up properly after the maximum connect attempts to ZooKeeper
Date Tue, 30 Aug 2011 15:21:37 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093808#comment-13093808
] 

Avery Ching commented on GIRAPH-17:
-----------------------------------

Sure.  The main part of this fix is

-            if (connectAttempts == 5) {
+            if (connectAttempts == maxConnectAttempts) {

Basically this condition should be hit if the max connect attempts was tried, but never was
because they because maxConnectAttempts is now 10 and became out of sync at some point (maxConnectAttempts
probably used to be 5).  

The limit is stil not configurable, we can address that in a later issue.

> Giraph doesn't give up properly after the maximum connect attempts to ZooKeeper
> -------------------------------------------------------------------------------
>
>                 Key: GIRAPH-17
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-17
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>            Priority: Minor
>         Attachments: ZooKeeperManager.java.diff
>
>
> This produces incorrect and strange behavior.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message