incubator-giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-21) Revise CODE_CONVENTIONS
Date Wed, 31 Aug 2011 17:38:10 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094714#comment-13094714
] 

Jakob Homan commented on GIRAPH-21:
-----------------------------------

I usually think of 80 chars as being 80 + 3 or 4 character buffer for semicolons, parens,
etc.  It's a good rule to have, but exceptions need to be made.  The complicating factor is
that with a 80 chars + 4 spaces per indent + lots of complicated Java type definitions (what
I wouldn't give for Scala's type aliases), the code gets pretty craggy, pretty fast.  Going
to two spaces would probably have a bigger impact than it might first appear, but I don't
have a strong opinion.  

> Revise CODE_CONVENTIONS
> -----------------------
>
>                 Key: GIRAPH-21
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-21
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Priority: Minor
>
> Currently there is a CODE_CONVENTIONS file in the base path of Giraph.  It's fairly sparse
and we have been assuming an 80 char limit per line.  It's good to have common conventions
so that the code doesn't get too messy.  Does anyone have any opinions on this now?  Probably
best to tackle early and then have something to follow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message