From general-return-65626-archive-asf-public=cust-asf.ponee.io@incubator.apache.org Thu Sep 6 00:37:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0896A180654 for ; Thu, 6 Sep 2018 00:37:57 +0200 (CEST) Received: (qmail 81107 invoked by uid 500); 5 Sep 2018 22:37:56 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 81095 invoked by uid 99); 5 Sep 2018 22:37:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2018 22:37:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9C494CB454 for ; Wed, 5 Sep 2018 22:37:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.691 X-Spam-Level: X-Spam-Status: No, score=0.691 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id FCkUv0iy7e56 for ; Wed, 5 Sep 2018 22:37:54 +0000 (UTC) Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2C8EC5F125 for ; Wed, 5 Sep 2018 22:37:54 +0000 (UTC) Received: by mail-wm0-f47.google.com with SMTP id c14-v6so9508710wmb.4 for ; Wed, 05 Sep 2018 15:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YlQ9RpxuRXqxAgYOCh0lu5uHOi19DlSjqWHQRqElwDU=; b=qqbPW7OeF9K1Debold6y0gvOmuNG2g+OLfo5a6+IyUALHU+NWafqOKgK0Y29AFeWyI vN9ikNcExospjP1iUYJjjGgvMCyyg+s1nIzqgetgs+hpCuX1V8/nnITZKWXvIyo8OriG UkKz1lyyVFfO596JOaUAToNjqUssCMiMdRC/s1MUwTCVUW5Nl6OoR0PZuZ4LPeI8geKo VkZ7f1FQbtibqicJF3uCSou+DbvCmDKYYQ1asXHEY6cS8G1EIP2++skrIPo6x3723+cz KYqn6ovkIddRhRD+1Wcx0nOyQnIzoUElNN9DXGWdAtKDNS04Vb9fj3O8ulBfP+38OHBR bdqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YlQ9RpxuRXqxAgYOCh0lu5uHOi19DlSjqWHQRqElwDU=; b=KtTL8G1c182GnfV/5DpzvlVZvbuJHRbtA11s+Vu6jCsbuKdUfjAzgTger3VR7sZPk4 cSoeGHZ7w+u4jwHt8nCq6CHjNPH0uit/qLCHsOsNReClaBDa4qgaKSfLUUmCjQ7sfnDr /qIp1e4/O5liFrsERz47OqN3CZfnoJGyc0P0Yl0RTQ2xpTIVRUXtnIDeHcH5ZhSd6z91 kIJv3fx8yk7u7amI4Yk6iBA4C7ZTJ8LEYWn7AwqcwuPqOlfnaajQlJTm+PWIz/EyZPG7 N35XWiZC6QD6+BsjH1J7MlOzZ4LUb14upXBbUHIsEDHpioLHWAU1XUx/7VdNxgaqKTiy rvaQ== X-Gm-Message-State: APzg51CqU7Kr5KtGg0fL+VgqOIe/mRoDUffOiCueZvZU2mCnhD0mU4CL 4YGM+Pf0+VVZx8pTOU8aRpu3r61HGBWHdGcOVgvvntU8lDk= X-Google-Smtp-Source: ANB0Vda8+VTMbjoU3pbBOgsZgPce8SBu1NQfTxiuNI2oDb7rj1Z6dbK7l1PnXU8gp2CznjdFraXixMOWoMQznup+x/Q= X-Received: by 2002:a1c:9c56:: with SMTP id f83-v6mr252501wme.135.1536187068390; Wed, 05 Sep 2018 15:37:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Willem Jiang Date: Thu, 6 Sep 2018 06:37:36 +0800 Message-ID: Subject: Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5] To: general@incubator.apache.org Cc: dev@dubbo.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I just checked the commit, it relates to system property setting, the fix is quite simple. I also checked the CI build, it looks like the CI is green[1] But my question is this fix was merged into 2.6.x branch for three weeks ago, why didn't we do the cherry pick it into 2.6.3 release branch last week? In Apache projects we maintain 2~3 different branches at the same time, cherry pick the fix acrocess different branches is a common practice. As someone already observered the test failure in earlier RC, we need to put some efforts on it (issue tracking) to make sure we fix it in the next RC. I know Dubbo team takes almost 1 month to cut this round release, but it's like a pain of growing. ServiceComb took more than a month to cut the first around release. We can do the release better if we learn something from it. Please revisit your release guide and checklist again, and encourage community to vote -1 once he find something wrong. [1]https://travis-ci.org/apache/incubator-dubbo/builds/420912788 Willem Jiang Twitter: willemjiang Weibo: =E5=A7=9C=E5=AE=81willem On Wed, Sep 5, 2018 at 6:39 PM Jerrick Zhu wrote: > > On Wed, Sep 5, 2018 at 6:10 PM Mark Thomas wrote: > > > On 03/09/18 03:32, Jun Liu wrote: > > > > > > > > > Please vote accordingly: > > > [X] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > Notes: > > =3D=3D=3D=3D=3D=3D > > > > Hash and signature match. > > > > Source zip matches Git tag (apart from expected differences of > > .gitignore and Maven wrapper) > > > > Builds and all tests except one pass. > > > > > > Issues from previous RC still present in this RC: > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > > > > The sha512 hashes are missing the '*' marker that indicates they are > > hashes for binary files rather than text files. Trivial issue. New RC > > not required. > > > > > > New issues > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > Tests seem to expect 127.0.0.2 to be a valid IP. If this is the case, > > consider documenting the requirements to run the tests somewhere obviou= s > > in the source tree. Trivial issue. New RC not required. > > > > I see the following test failures: > > Oracle Java 8 update 181 > > Ubuntu 18.04.1 LTS (fully patched) > > Maven 3.5.4 > > > > This fails consistently for me: > > > > -----------------------------------------------------------------------= -------- > > Test set: com.alibaba.dubbo.config.AbstractInterfaceConfigTest > > > > -----------------------------------------------------------------------= -------- > > Tests run: 38, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.119 > > sec <<< FAILURE! - in com.alibaba.dubbo.config.AbstractInterfaceConfigT= est > > checkApplication1(com.alibaba.dubbo.config.AbstractInterfaceConfigTest) > > Time elapsed: 0.006 sec <<< FAILURE! > > junit.framework.ComparisonFailure: expected:<10[0]> but was:<10[]> > > at > > > > com.alibaba.dubbo.config.AbstractInterfaceConfigTest.checkApplication1(= AbstractInterfaceConfigTest.java:90) > > > > I note that this test has been observed to fail for other community > > members in earlier RCs. > > > > Yes, it's true, we've fixed it on 2.6.x branch, and will be in next > release, 2.6.4, but not in 2.6.3. > > check the commit: > https://github.com/apache/incubator-dubbo/commit/93d2eb674b094ee4feee0ef1= e46096098c5a22b4 > > > > I can recreate this failure on the command line but not in an IDE. > > > > Whether this failure is significant enough to halt the release is > > something for those more knowledgeable about Dubbo than I to decide. > > > > This is the result of mutual influence of unit test cases, not the > functional problem. So IMO, this release could be go ahead. What do other > people think? > > > > > > > > Mark > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org For additional commands, e-mail: general-help@incubator.apache.org