From general-return-65116-archive-asf-public=cust-asf.ponee.io@incubator.apache.org Sat Jul 21 20:33:45 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E09F4180634 for ; Sat, 21 Jul 2018 20:33:44 +0200 (CEST) Received: (qmail 98834 invoked by uid 500); 21 Jul 2018 18:33:43 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 98775 invoked by uid 99); 21 Jul 2018 18:33:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Jul 2018 18:33:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4F1DAC195F for ; Sat, 21 Jul 2018 18:33:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.388 X-Spam-Level: X-Spam-Status: No, score=0.388 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id eVECFCZx3n0U for ; Sat, 21 Jul 2018 18:33:40 +0000 (UTC) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B46185F33D for ; Sat, 21 Jul 2018 18:33:39 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id e19-v6so12291574edq.7 for ; Sat, 21 Jul 2018 11:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jruMs0OqdrMw10n4BBOSRIbsWeyb50YdTUFSym/db6g=; b=HLwuP7HVi2uDH/lsvpWHunoglo4rhabgnR68omI2vO7KWGgz435DXCn1aEzkMKA/+A 6jucXpkXn6O8DBqTIIS01sXsHRoFuFn4FewUMiIK4FYTjta7ml/IZE2Tsv9wNsyK8BP6 w8VVCQkMHY8NvNbgmUCZ5xa4kP1tTRjjJRF5nQJ/qTTpf7di2sqgdE70QusCYVEywikU /gWTiTtvmm+moowbzw2h5ItdKEbAwM0AxNjqCcqrzTqEte046xnKFvK1WQYlCwPlG52j mUYYpXZTSgE2HhSa6pnY3tWMpbdCK52Pi6K0CkLyhSpQn26y2DQ7c4Xo/8ydkgVRwO6N XvjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jruMs0OqdrMw10n4BBOSRIbsWeyb50YdTUFSym/db6g=; b=rLX4+hdk8Wfyp6S5Q3yptmqd4dHLdNbEyr062qq3I8nKqiOev02KDHrGyUz5bYbm7U oospVTbsUjWGb7KONW2pPhuia3A8s0DTk2FtIGfCGnTk0jNwXCyvktfFSEmRccsyzKK+ jsNpNA9s2Pj+wdzU5KeHl4hAUnLcmRWKiia2045KdUEHges/iga/PF1cv8nX20tGeHPW Yb1a0Sb9liFxNcQOpAH25n0fYSQ0DdbdBi6jb5uv6UW+g8EeY6WYONs9bfHkDJDRocr3 j7Sp7UZXeB9F4OzhwWzjG41oqhL8tAq937MjcdP3aDbH65HMp8IIjyI95xmZaZi8bPmY gl6g== X-Gm-Message-State: AOUpUlFL244QzbmKz+JZ5kcdMEA3RjvieL/PF6bGmYrxBBfT6j9RtVAN /hTVJEmEEBPbsBBTWX1bnKbqzfKlKYLw X-Google-Smtp-Source: AAOMgpda4IlwX0g+6MSqBJEUw7EaFicfDa+Dtbdcslr0RGqs6VfgCkmI6LRZ8UOM5SSQc8Qt/nSCrA== X-Received: by 2002:a50:b613:: with SMTP id b19-v6mr7529423ede.255.1532198018317; Sat, 21 Jul 2018 11:33:38 -0700 (PDT) Received: from ?IPv6:2001:984:4722:1:9da9:3510:7785:4299? ([2001:984:4722:1:9da9:3510:7785:4299]) by smtp.gmail.com with ESMTPSA id d4-v6sm2117012edp.80.2018.07.21.11.33.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Jul 2018 11:33:37 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: [VOTE] Release Airflow 1.10.0 From: Bolke de Bruin In-Reply-To: <8371C9DE-2B30-48F9-AD2D-DE9DFC75D593@classsoftware.com> Date: Sat, 21 Jul 2018 20:33:35 +0200 Cc: dev@airflow.incubator.apache.org Content-Transfer-Encoding: quoted-printable Message-Id: <4E53854B-AA12-4135-B012-090384D6B04E@gmail.com> References: <7E9898AA-155A-4808-8785-50EBA01DA7FD@gmail.com> <92101DC4-A95A-4CA1-81BE-0CAB97231FB9@gmail.com> <80915AE0-D188-411D-B2C1-498EB1EDE475@gmail.com> <2A66BD90-8FA7-41D2-8526-CE354F0ABA51@gmail.com> <67A1414F-9C2C-4AF5-B5B0-6EEF07869527@gmail.com> <8371C9DE-2B30-48F9-AD2D-DE9DFC75D593@classsoftware.com> To: general@incubator.apache.org X-Mailer: Apple Mail (2.3445.8.2) Hi Justin, Thank you for the thorough review! I have created AIRFLOW-2779 to track = most of the issues you have raised.=20 On the GPL dependency you mentioned. We are not distributing GPL = sources, not in source or in binary form. This has never been the case. = In the third degree there potentially was a GPL issue during runtime. = The author of the package in question (unidecode) when asked mentioned = several times that he considered the usage equal to an API (ie. like the = Linux kernel exposing a set of generic calls) and the API could be = implemented by an alternative. This was discussed in LEGAL-362, which = you took part in. We managed to convince the upstream package maintainers (python-slugify = and python-nvd3) to allow a patch that allowed switching to a different = API implementation by setting a environment variable while installing = their packages and to release new versions. However it is not the = default for them. This means at least that the situation we are now in = is an improvement over the previous releases (1.8.0 -> 1.8.1 -> 1.8.2 -> = 1.9.0) as there was no way switch and avoid the package before. As to our solution (for now). Python packages are often installed = site-wide and can be part of the dependencies of other packages. While = we maybe could enforce the installation of the non-GPL API it = would/could 1) interfere with other packages on the same system that do = not set this environment variable explicitly. 2) If any the other = packages upgrades without setting this variable it would pull in the GPL = API. So we decided that it would be better to educate the user and make = it part of the install instructions. We can reconsider, but we cannot solve #1 and #2. Which, in my opinion, = would make it more opaque to the users.=20 Given the current situation is at least improvement over the old = situation can you reconsider your -1 for this release and preferably = agree with our approach (or maybe have an improvement over it)?=09 Cheers Bolke > On 21 Jul 2018, at 03:03, Justin Mclean = wrote: >=20 > Hi, >=20 > -1 (binding) because of GPL dependancy >=20 > I checked the source release: > - incubating in name > - signatures and hash good but please remove md5 hashes and don=E2=80=99= t publish then > - DISCLAIMER exists > - Year in NOTICE is not correct "2016 and onwards=E2=80=9D isn=E2=80=99t= valid as copyright has an expiry date > - NOTICE and LICENSE have a couple of minor issues (see below) > - Several files look to have incorrect headers with copyright lines = [8][9][10] Are these actually 3rd party files? > - No unexpected binary files > - Failed to install, probably my set up. Would be nice to note python = version required and supported OS=E2=80=99s in INSTALL. >=20 > LICENSE is: > - missing jQuery clock [3] and typeahead [4], as they are ALv2 it=E2=80=99= s not required to list them but it=E2=80=99s a good idea to do so. > - missing the license for this [5] > - this file [7] oddly has =C2=A9 2016 GitHub, Inc.at the bottom of it >=20 > This files [1][2] seem to be 3rd party ALv2 licensed files that refers = to a NOTICE file, that information in that NOTICE file (at the very = least the copyright into) should be in your NOTICE file. This should = also be noted in LICENSE. >=20 > I also find it very odd that the GPL dependancy unidecode is opt out, = rather than opt in (ie the user has to do something to not get it) and = that makes it non optional IMO [6]. Can you explain why it was done = this way and I=E2=80=99ll consider changing my vote. >=20 > Thanks, > Justin >=20 > 1. /airflow/security/utils.py > 2. ./airflow/security/kerberos.py > 3. ./airflow/www_rbac/static/jqClock.min.js > 4. ./airflow/www/static/bootstrap3-typeahead.min.js > 5. ./apache-airflow-1.10.0rc2+incubating/scripts/ci/flake8_diff.sh > 6. https://www.apache.org/legal/resolved.html#optional > 7. ./docs/license.rst > 8. airflow/contrib/auth/backends/google_auth.py > 9. /airflow/contrib/auth/backends/github_enterprise_auth.py > 10. /airflow/contrib/hooks/ssh_hook.py > 11. /airflow/minihivecluster.py > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > For additional commands, e-mail: general-help@incubator.apache.org >=20 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org For additional commands, e-mail: general-help@incubator.apache.org