From general-return-64983-archive-asf-public=cust-asf.ponee.io@incubator.apache.org Sun Jul 8 09:15:25 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CA558180630 for ; Sun, 8 Jul 2018 09:15:24 +0200 (CEST) Received: (qmail 78781 invoked by uid 500); 8 Jul 2018 07:15:23 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 78769 invoked by uid 99); 8 Jul 2018 07:15:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Jul 2018 07:15:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 31236C0110 for ; Sun, 8 Jul 2018 07:15:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.946 X-Spam-Level: X-Spam-Status: No, score=0.946 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.697, SPF_NEUTRAL=0.652, T_DKIMWL_WL_MED=-0.01, WEIRD_PORT=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=classsoftware-com.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id zC0fEqpIVVJD for ; Sun, 8 Jul 2018 07:15:19 +0000 (UTC) Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2006F5F5FC for ; Sun, 8 Jul 2018 07:15:19 +0000 (UTC) Received: by mail-pf0-f169.google.com with SMTP id i26-v6so47711pfo.12 for ; Sun, 08 Jul 2018 00:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=classsoftware-com.20150623.gappssmtp.com; s=20150623; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=VAk3aocHcg4eKk+nEIcw0UzDg3nzzN5xz8Zd81XesmM=; b=0XDWfE7Xl5wsbfO59MrQNOEUxIz9eyG1gVyiyGDHYyT4aaF2ZFfIUtkOwfOcp1O7A0 pCXKnGBWo246bB4kObGSb+65HIKDRz4YhATBNxLwuAYoL5rtTBIUP8BvU4RLXknUpFkG f3I6fI5eP2kL9Q+KEuPVCxmeP9A7bE/AZ9MesrExuRYoMuemSsshyaK+vOGD4dbxS073 94Umrzx1YH043Lk3rPXTYPwu+aJdhcG9rB0trsgPq2QjBNfVyWTtN4jnD5/cbIv2lBIw r4wTNV7oD0cci5C9IIAaFeTJzTDy1kF5tBcGyJY5UHJE+AnvEfvTgPsRzcuNSvzR9e9s rc5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=VAk3aocHcg4eKk+nEIcw0UzDg3nzzN5xz8Zd81XesmM=; b=JqCY5n2XdoVWCJzboN6fphKpAxD3Fjm5xNYNjDlvrcD0pX92AtI8H1EeCK7Za7zi+G j0RoCW7oXZqDAGBHLJjSQFUa1UuE4ZlVVP8WDr3yOb7Yhw1PfqwZ9VYVd2vaxB78IYTl jrvHFWzpiAHE0rS29dLSNJDXrHZ/KpPosm7zHEpiEj52y2uKTBSO7/kDF5z1BgwEFVVl WF3AEj46Tvn4ooARR25oRXFPhEiObnAJFVB5sKgGjk/m2OTQ9xBruSVE61eB7UP5oqY5 roxjBw+2CAeGIbVbzBMVTlVM6scRgmbqspWbUg4Hgr9KPsJhYXphNTrfNUDED5TI4Lty UTNQ== X-Gm-Message-State: APt69E3ijIDXOInN99zqO1mj70a3soyqeNxcJY4M0PGHUNF1tv+TMS3r mlrTA1v+Jpj5eG2wAs/3MHKt674+Ulo= X-Google-Smtp-Source: AAOMgpdO9YaNil1kh7Obekbto7s5XVXI11c5U/WKxw90X2rKSYX2A0+f9sgOnRVYBuInOlmiV9AkLw== X-Received: by 2002:a63:2c0d:: with SMTP id s13-v6mr15058790pgs.37.1531034111733; Sun, 08 Jul 2018 00:15:11 -0700 (PDT) Received: from [192.168.0.13] (124-169-15-60.dyn.iinet.net.au. [124.169.15.60]) by smtp.gmail.com with ESMTPSA id a11-v6sm15930745pfl.66.2018.07.08.00.15.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jul 2018 00:15:10 -0700 (PDT) From: Justin Mclean Content-Type: multipart/alternative; boundary="Apple-Mail=_7B827E97-28D8-4F3C-BDB3-803FA01E6D7D" Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: [VOTE] Release Apache Amaterasu (incubating) 0.2.0 (rc4) Date: Sun, 8 Jul 2018 17:15:05 +1000 References: To: general@incubator.apache.org In-Reply-To: Message-Id: <0BAAFB9A-DCEF-46A4-954F-DFCFD035CA2A@classsoftware.com> X-Mailer: Apple Mail (2.3445.6.18) --Apple-Mail=_7B827E97-28D8-4F3C-BDB3-803FA01E6D7D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, +1 (binding) Sorry did this a while back but forgot to send I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exists - LICENSE is OK but could be improved - NOTICE year needs updating - no unexpected binary files - all ASF source files have correct headers - can compile from source For the license it would be nice to mention the version of the bundled = software and what the license is rather than just pointing to the = license file.Also the license files pointed to also contain multiple = licenses which is a little surprising, it=E2=80=99s may be better to put = that info in the LICENSE file an/or only have a single license per file. The source release also contains multiple archives [2][3][4][5] which = makes it harder to review, could these be expanded in the release? Thanks, Justin 1. incubator-amaterasu-version-0.2.0-incubating-rc4 = /executor = /src = /main = /resources= /codegen.= py 2. = incubator-amaterasu-version-0.2.0-incubating-rc4/executor/src/test/resourc= es/py4j-0.10.4-src.zip 3. = incubator-amaterasu-version-0.2.0-incubating-rc4/executor/src/test/resourc= es/py4j.tar.gz 4. = incubator-amaterasu-version-0.2.0-incubating-rc4/executor/src/test/resourc= es/pyspark.tar.gz 5. = incubator-amaterasu-version-0.2.0-incubating-rc4/executor/src/test/resourc= es/pyspark.zip= --Apple-Mail=_7B827E97-28D8-4F3C-BDB3-803FA01E6D7D--