incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bertrand Delacretaz <bdelacre...@apache.org>
Subject Re: [VOTE]: Release Apache OpenWhisk (Incubating): main module 0.9.0 [RC2]
Date Fri, 13 Jul 2018 13:23:42 GMT
On Wed, Jul 11, 2018 at 4:38 PM Vincent S Hou <shou@us.ibm.com> wrote:
> ...This is a call for vote to release Apache OpenWhisk (Incubating): main module version
0.9.0...

+1 for the release of incubating-netbeans-java-9.0-source.zip with
SHA512= 9b3a4631d99e004b38386550f36c1500270b86aa0d4a899fee0a2037649f182c1ecf497b13cc81de57c56fe9a8c45d74d8f070df9fd9e2ece10e606c6ba0167f

Here's what I checked:

-Signatures and digests match, RSA key ID 2C4CF320

-LICENSE.txt NOTICE.txt DISCLAIMER.txt  look good to me.

-File header checks pass using the scancode tool from
https://github.com/apache/incubator-openwhisk-utilities

-build with gradle distDocker works (with a local Docker setup and Gradle 4.8.1)

-Release archive filenames are ok

-I don't see binary files in the release archive which is good

I have a few comments that do not block the release but need to be
taken care of by the podling - there might already be tickets for
those, I haven't checked.

1) The .scala code files are in whisk.* packages, that should be
org.apache.openwhisk.* for an Apache project. Something to fix later.

2) There's an RSA private key in the source archive, if it's for
testing purposes it should be clearly identified as such (ideally
named test- something) to reassure people that it's not problematic to
distribute it (./ansible/roles/nginx/files/openwhisk-server-key.pem).

-Bertrand (OpenWhisk incubation mentor)

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message