incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
Date Sun, 10 Jun 2018 09:57:34 GMT

Hi,

Please remove the .md5 hashes.

+1 binding

I checked:
- incubating in name
- signatures and hashes correct
- LICENSE is fine
- NOTICE is OK but has wrong year please fix
- no unexpected binary files
- source files have headers
- can compile from source

I think I agree with Matteo that those protobuf files should not have an ASF header. Generally
changes to a file are under the original license, see [1], but it not a big issue as BSD is
an Category A license and you are including the full license text. It’s also seems odd because
the license calls them out as BSD licensed.

Thanks,
Justin

1. https://www.apache.org/legal/src-headers.html#3party
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message