From general-return-64399-archive-asf-public=cust-asf.ponee.io@incubator.apache.org Mon May 14 20:34:25 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 453D9180627 for ; Mon, 14 May 2018 20:34:25 +0200 (CEST) Received: (qmail 13855 invoked by uid 500); 14 May 2018 18:34:23 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 13834 invoked by uid 99); 14 May 2018 18:34:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 May 2018 18:34:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 943C1C080A for ; Mon, 14 May 2018 18:34:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.369 X-Spam-Level: ** X-Spam-Status: No, score=2.369 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id t0w2axL9MY_p for ; Mon, 14 May 2018 18:34:21 +0000 (UTC) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 054015F18B for ; Mon, 14 May 2018 18:34:21 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id n10-v6so16949952wmc.1 for ; Mon, 14 May 2018 11:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0EPCZI0iqElaUXviKwg+Awzzh2YmaEpyF3V7bXzFR5E=; b=pypuRpUIn5ZR/4QRZQq+/hlmp5uMGTpZmm2SZyowoMQR3zPbVCdDIfxNmQwVy6Kcie +HLAxoeGg6a6qxUSnJQXRR4d3lBgPquRnkP3Wmgu+57E+oDVDqXOhl1szCkOD5Tt0GmZ ueiq3qgjoDuYbAxvGpbrgRMMHgc5UillERsNMMJ0CT8l2qkPm4QEO6vnlWT9RobR+E4D KXL+AeOMVBClV3wNJV9zTTv85SZX14pQLdsdxKuu2RqXyTzCuP5nltC6B0gRCs3ZOvdm YHfbZ1G1HbY3Ld+D6toy7HtGKVvBQYZSyegU2yjFWpJcubX5r0kG3zLpZ+pcYjyRuWJp Wzfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0EPCZI0iqElaUXviKwg+Awzzh2YmaEpyF3V7bXzFR5E=; b=nehJYcp9ZwigpgqzxNOckvTwq+bXySaHRH4OQjCTFaoK4YOCk272LLFuHFme/3Lu4t hqYWmiQuN3Ni/eFnbCccYPRprZDSDVD3Wirrx+4FU60Avf18SqMkKHio5v0pFwBzY1Bu U+6Srm0ksk7/oBNpgPWGWUJ3PTdVVmWxZVvf9y66BugLC+LEIPe7s39x5ykJnRXxReeZ lUFdZmx3onAzxM0xIZsEM27A7agUTh/Bl6nLIBONxH7IQTfGlVMXiWNJP3qpcLKmStQI AMS4OsN2/xciOylfWfFOynZQ9LzaIIPwN8VM4S4E7Lc9hD3O0eEGvX4ypW3mVDd3X7lt hsDg== X-Gm-Message-State: ALKqPwc0nANhzG1TJ1I3kuccX5Qvm6dvT+qdq5ab/+VU+JGowh/fqm4d wBZBvslkfkjQ1gVi36NCbevPpnkxqzr2eE4p9ur5HA== X-Google-Smtp-Source: AB8JxZpMAOuNESHcxriaZCwSDiBl6zSn8Ochl2PpBBqI8T0VX5ZaDel+D2jvC+7cxSb7HM5+6NvjJbY/mAaT2thGrxM= X-Received: by 2002:a1c:b4e:: with SMTP id 75-v6mr5593932wml.32.1526322860562; Mon, 14 May 2018 11:34:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.196.185 with HTTP; Mon, 14 May 2018 11:34:19 -0700 (PDT) In-Reply-To: <2EB4714F-C94E-4DA4-AFF1-97BD024A3810@comcast.net> References: <16FD284C-3A5F-490D-B59E-E089390F5855@jaguNET.com> <942F6E7E-3788-413F-8493-957831C4E09F@classsoftware.com> <2EB4714F-C94E-4DA4-AFF1-97BD024A3810@comcast.net> From: Sijie Guo Date: Mon, 14 May 2018 11:34:19 -0700 Message-ID: Subject: Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3 To: dev@pulsar.incubator.apache.org Cc: general@incubator.apache.org Content-Type: multipart/alternative; boundary="000000000000ea9e10056c2ebbed" --000000000000ea9e10056c2ebbed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 14, 2018 at 11:16 AM, Dave Fisher wrote= : > Hi - > > > On May 14, 2018, at 10:57 AM, Sijie Guo wrote: > > > > On Sun, May 13, 2018 at 7:49 PM, Matt Sicker wrote: > > > >> On 13 May 2018 at 12:10, Matteo Merli wrote: > >> > >>> The code in question is testing a feature that takes Jars from a user > and > >>> execute the code contained. Indeed the Jar should not be in the > sources, > >>> though I believe the test is correct here: we need to validate the > >> specific > >>> feature by dynamically loading a Jar. > >>> > >> > >> By generating the binary jar from source files at test time, you'd avo= id > >> bundling any binary output files. > >> > > > > I made the original change long time back in pulsar-functions for testi= ng > > submitting user-defined function. When we first contribute > pulsar-functions > > to pulsar, we probably didn't clean that up. > > The intention behind that change is not including any source code or ja= r > in > > the test dependency tree. As including source code would make the testi= ng > > function as part of the test dependency, it would volatile the purpose = of > > testing submitting a user defined function. In this case, > > "multifunction.jar" is the a "user-defined" function as the test > resource. > > To be succinct The ASF produces open source software and including a > pre-compiled binary in the release means that the project fails the open > source definition. [1] > > It really doesn=E2=80=99t matter how or why. You will need to provide the= source > (as simple as it might be) and the maven configuration to build that > trivial jar. > Okay. So if we provide the source file of that jar, is it allowed to include a pre-compiled binary as test resources? > > Regards, > Dave > > [1] https://opensource.org/osd > > > > > > > > > > > > >> > >> > >>>> (e.g., injecting a > >>> module-info.class file at build time rather than requiring Java 9+ to > >> build > >>> regardless). > >>> > >>> I don't see any place in the code where we are using > "module-info.class" > >>> and the project requires Java 8 and not 9. > >>> > >> > >> Sorry for the confusion, that was just an example from a problem I've > seen > >> before in another project. > >> > >> -- > >> Matt Sicker > >> > > --000000000000ea9e10056c2ebbed--