incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anirudh <anirudh2...@gmail.com>
Subject Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC2
Date Sat, 12 May 2018 07:11:10 GMT
Hi Justin,

Thank you! They were first added as part of this PR:
https://github.com/apache/incubator-mxnet/pull/5834. As you can see there
is a LICENSE in src/operator/contrib/ctc_include which is Apache v2.0
license. I am assuming that the intention was to keep the license of files
in the directory or subdirectory the same. I think we should be good to add
the header for Apache v2.0 license:
>  src/operator/contrib/ctc_include/detail/cpu_ctc.h
>  src/operator/contrib/ctc_include/detail/ctc_helper.h
>  src/operator/contrib/ctc_include/detail/gpu_ctc.h
>  src/operator/contrib/ctc_include/detail/gpu_ctc_kernels.h
>  src/operator/contrib/ctc_include/detail/hostdevice.h

Please confirm.

For the docs directory, we did something similar to what other popular
Apache projects like spark did:
https://github.com/apache/spark/tree/master/docs. (adding docs directory to
rat-excludes)

At this point I want to ask you what your blocking concerns are.
Is it only the CC-BY-2.5 license for DevGuide.md in googletest submodule or
is it also the missing headers for contrib and the broad rat excludes ?

Anirudh




On Fri, May 11, 2018 at 11:38 PM, Justin Mclean <justinmclean@me.com> wrote:

> Hi,
>
> > In contrib/, I found a few files which don't have a license or have a
> > license but not the full text:
> >  src/operator/contrib/psroi_pooling-inl.h
> >  src/operator/contrib/ctc_include/detail/cpu_ctc.h
> >  src/operator/contrib/ctc_include/detail/ctc_helper.h
> >  src/operator/contrib/ctc_include/detail/gpu_ctc.h
> >  src/operator/contrib/ctc_include/detail/gpu_ctc_kernels.h
> >  src/operator/contrib/ctc_include/detail/hostdevice.h
>
> Well they do have a license it’s just unclear what it is as they have no
> header. Do you know where those files came from and how they were licensed?
>
> > In docs/ directory, the files that don't have a license are the .md,
> .html,
> > .js , .css, .svg.
> > I am assuming that these files don't need a license and thus we are good
> to
> > put them in rat excludes file.
>
> .js files are code and as such should have a header either [1] or [2]. The
> html files should have a header also [4]. There’s only a few exception for
> file not having headers [3]
>
> Thanks,
> Justin
>
> 1. https://www.apache.org/legal/src-headers.html#headers
> 2. https://www.apache.org/legal/src-headers.html#3party
> 3. https://www.apache.org/legal/src-headers.html#faq-exceptions
> 4. https://www.apache.org/legal/src-headers.html#faq-siteindocs
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message