incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matteo Merli <mme...@apache.org>
Subject Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3
Date Sun, 13 May 2018 17:10:42 GMT
Hi Matt,

can you expand a bit more on the issue, because I'm not 100% sure I
understand it correctly.

> -1 as well. For strange build requirements that need to inject class
files,
that would still only be applied to the binary artifacts

The code in question is testing a feature that takes Jars from a user and
execute the code contained. Indeed the Jar should not be in the sources,
though I believe the test is correct here: we need to validate the specific
feature by dynamically loading a Jar.

> (e.g., injecting a
module-info.class file at build time rather than requiring Java 9+ to build
regardless).

I don't see any place in the code where we are using "module-info.class"
and the project requires Java 8 and not 9.

Thanks,
Matteo

On Sun, May 13, 2018 at 8:46 AM Matt Sicker <boards@gmail.com> wrote:

> -1 as well. For strange build requirements that need to inject class files,
> that would still only be applied to the binary artifacts (e.g., injecting a
> module-info.class file at build time rather than requiring Java 9+ to build
> regardless).
>
> On 12 May 2018 at 21:17, Dave Fisher <dave2wave@comcast.net> wrote:
>
> > Hi Pulsar Devs,
> >
> > Thanks Justin! I know that Pulsar Functions are new.
> >
> > $ jar tvf apache-pulsar-2.0.0-rc1-incubating/pulsar-functions/
> > utils/src/test/resources/multifunction.jar
> >      0 Wed Dec 13 01:00:28 PST 2017 META-INF/
> >    147 Wed Dec 13 01:00:28 PST 2017 META-INF/MANIFEST.MF
> >      0 Wed Dec 13 00:58:36 PST 2017 org/
> >      0 Wed Dec 13 00:58:36 PST 2017 org/apache/
> >      0 Wed Dec 13 00:58:36 PST 2017 org/apache/pulsar/
> >      0 Wed Dec 13 00:58:36 PST 2017 org/apache/pulsar/functions/
> >      0 Wed Dec 13 00:58:36 PST 2017 org/apache/pulsar/functions/runtime/
> >      0 Wed Dec 13 00:58:56 PST 2017 org/apache/pulsar/functions/
> > runtime/functioncache/
> >    683 Wed Dec 13 00:57:10 PST 2017 org/apache/pulsar/functions/
> > runtime/functioncache/AddFunction.class
> >
> > AddFunction is nowhere in the source. This is something that must be
> > corrected.
> >
> > Sorry, but I am going to change my votes to +0 until there is an
> > explanation. One option would be to remove this test …
> >
> > Please keep the eye out for jars and tars in the source.
> >
> > Regards,
> > Dave
> >
> > On May 12, 2018, at 3:52 PM, Justin Mclean <justin@classsoftware.com>
> > wrote:
> >
> > Hi,
> >
> > Sorry but it’s -1 binding due to compiled code in source release.
> >
> > Frankly I’m surprised to see so many +1s with this obvious issue.
> >
> > I checked:
> > - incubating in name
> > - signatures and hashes correct
> > - DISCLAIMER exists
> > - LICENSE and NOTICE good
> > - Unexpected jar in source release [1]
> > - All source files have headers
> >
> > Thanks,
> > Justin
> >
> >
> > 1.  pulsar-functions/utils/src/test/resources/multifunction.jar
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
> >
>
>
> --
> Matt Sicker <boards@gmail.com>
>
-- 
Matteo Merli
<mmerli@apache.org>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message