incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: [Vote] Release of Apache-Griffin-0.2.0-incubating [RC1]
Date Fri, 23 Mar 2018 04:08:45 GMT
With those notes, I change my vote to -1 as well.

On 22 March 2018 at 22:42, John D. Ament <johndament@apache.org> wrote:

> On mine I get 3 files failing
>
> Unapproved licenses:
>
>   DEPENDENCIES
>   griffin-doc/service/postman/griffin.json
>   griffin-doc/service/postman/griffin_environment.json
>
> Doing what I assume is the same thing as Matt (mvn apache-rat:check from
> the source release folder) . In addition to what he's noted, the year in
> your NOTICE file should be updated to 2018.  The resulting output files
> need a little bit of work:
>
> - measure's JAR shows the notice for Avro.  It also packs in additional
> dependencies that are not apache licensed (they're all Cat B so they're
> fine).  In the next release, please create dedicated NOTICE and LICENSE
> files for this JAR.
> - Similar issues exist in the service JAR, where the spring boot JAR
> includes many other dependencies, some of which carry their own NOTICE
> (Jackson, Tomcat) or other licenses.  What's harder is that you're using
> Hibernate, which is an LGPL Cat-X dependency and cannot be included in the
> JAR.  This is going to have to come out.
> - The resulting output from your UI build should have licenses in place for
> font awesome, glyphicons.  I'm not sure whats in your vendor.min.js but
> based on your node_modules you may need to call out additional
> license/notice contents.
>
>
> Sorry, but -1.
>
> On Thu, Mar 22, 2018 at 11:20 PM Matt Sicker <boards@gmail.com> wrote:
>
> > I should note that I'm building this from the source zip file.
> >
> > On 22 March 2018 at 22:19, John D. Ament <johndament@apache.org> wrote:
> >
> > > When you execute a release using the Apache parent pom, one of the
> files
> > > generated is a DEPENDENCIES file.  For almost all projects, this file
> is
> > > empty.  However it doesn't play well with rat.
> > >
> > > John
> > >
> > >
> > > On Thu, Mar 22, 2018 at 11:18 PM Lionel Liu <lionelliu@apache.org>
> > wrote:
> > >
> > >> Hi Matt,
> > >>
> > >> What DEPENDENCIES files are causing the rat check fail in your
> > >> environment ?
> > >> We had set the exclusion list of some files in pom.xml, with profile
> id
> > >> apache-release, the rat check will success by running `mvn
> > >> -Papache-release
> > >> clean apache-rat:check`
> > >>
> > >> Thanks,
> > >> Lionel
> > >>
> > >> On Fri, Mar 23, 2018 at 10:41 AM, Matt Sicker <boards@gmail.com>
> wrote:
> > >>
> > >> > +1
> > >> >
> > >> > * GPG checked
> > >> > * Build/test checked
> > >> >
> > >> > Note that your DEPENDENCIES file is causing the rat check to fail
> and
> > >> > should probably be added to the exclusion list. I also had a couple
> > test
> > >> > failures in Java 10 relating to some Spark classes in case you're
> > >> curious.
> > >> >
> > >> > On 22 March 2018 at 21:23, Lionel Liu <lionelliu@apache.org>
wrote:
> > >> >
> > >> > > +1
> > >> > >
> > >> > > Thanks,
> > >> > > Lionel
> > >> > >
> > >> > > On Fri, Mar 23, 2018 at 10:21 AM, William Guo <guoyp@apache.org>
> > >> wrote:
> > >> > >
> > >> > > > +1
> > >> > > >
> > >> > > > Thanks,
> > >> > > > William
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > On Fri, Mar 23, 2018 at 10:13 AM, Lionel Liu <
> > lionelliu@apache.org>
> > >> > > wrote:
> > >> > > > > Hi all,
> > >> > > > >     The Apache Griffin community has voted on and approved
a
> > >> proposal
> > >> > > to
> > >> > > > > release Apache Griffin 0.2.0-rc1.
> > >> > > > >     We now kindly request that the Incubator PMC members
> review
> > >> and
> > >> > > vote
> > >> > > > on
> > >> > > > > this incubator release candidate.
> > >> > > > >
> > >> > > > >     Apache Griffin is data quality service for modern
data
> > >> system, it
> > >> > > > > defines a standard process to define, measure data
quality for
> > >> > > well-known
> > >> > > > > dimensions. With Apache Griffin, users will be able
to quickly
> > >> define
> > >> > > > their
> > >> > > > > data quality requirements and then get the result in
near real
> > >> time
> > >> > in
> > >> > > > > systematical approach.
> > >> > > > >
> > >> > > > >
> > >> > > > >     Griffin vote thread
> > >> > > > >
> > >> > > > > https://lists.apache.org/thread.html/
> > >> 658a1a5a6720783d13cdd5e3f473fa
> > >> > > > 00fd491e4c691c3aedfce81bf3@%3Cdev.griffin.apache.org%3E
> > >> > > > >     Griffin vote result thread
> > >> > > > >
> > >> > > > > https://lists.apache.org/thread.html/
> > >> c3e5a04bebfe8b3a6904642db723fe
> > >> > > > 89b07d26553d8a6fc13961ec1e@%3Cdev.griffin.apache.org%3E
> > >> > > > >
> > >> > > > >     The source tarball, including signatures, digests,
etc.
> can
> > be
> > >> > > found
> > >> > > > at:
> > >> > > > >
> > >> > > > > https://dist.apache.org/repos/dist/dev/incubator/griffin/0.
> > >> > > > 2.0-incubating
> > >> > > > >
> > >> > > > >     The tag to be voted upon is 0.2.0-incubating:
> > >> > > > >
> > >> > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-griffin.
> > >> > > > git;a=shortlog;h=refs/tags/griffin-0.2.0-incubating
> > >> > > > >
> > >> > > > >     The release hash is :
> > >> > > > >
> > >> > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-griffin.
> > >> > > > git;a=commit;h=fe3cde132d950fbdc35aa33bccac89e6c02cef8c
> > >> > > > >
> > >> > > > >     The Nexus Staging URL:
> > >> > > > >     https://repository.apache.org/content/repositories/
> > >> > > > orgapachegriffin-1010
> > >> > > > >
> > >> > > > >     Release artifacts are signed with the following
key:
> > >> > > > >     0CE81C56C324D162F97A06480C001A229453521F
> > >> > > > >
> > >> > > > >     KEYS file available:
> > >> > > > >
> > https://dist.apache.org/repos/dist/dev/incubator/griffin/KEYS
> > >> > > > >
> > >> > > > >     For information about the contents of this release,
see:
> > >> > > > >
> > >> > > > > https://dist.apache.org/repos/dist/dev/incubator/griffin/0.
> > >> > > > 2.0-incubating/CHANGES.txt
> > >> > > > >
> > >> > > > >
> > >> > > > >     Please download the release candidate and evaluate
the
> > >> necessary
> > >> > > > items
> > >> > > > > including checking hashes, signatures, build from source,
run
> > and
> > >> > test.
> > >> > > > >     Please vote on releasing this package as Apache
Griffin
> > >> > > > 0.2.0-incubating
> > >> > > > >     The vote will be open for 72 hours.
> > >> > > > >     [ ] +1 Release this package as Apache Griffin
> > 0.2.0-incubating
> > >> > > > >     [ ] +0 no opinion
> > >> > > > >     [ ] -1 Do not release this package because ...
> > >> > > > >
> > >> > > > >
> > >> > > > > Thanks,
> > >> > > > > Lionel
> > >> > > > > on behalf of Apache Griffin PPMC
> > >> > > >
> > >> > > > ------------------------------------------------------------
> > >> ---------
> > >> > > > To unsubscribe, e-mail: general-unsubscribe@incubator.
> apache.org
> > >> > > > For additional commands, e-mail:
> > general-help@incubator.apache.org
> > >> > > >
> > >> > > >
> > >> > >
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > Matt Sicker <boards@gmail.com>
> > >> >
> > >>
> > >
> >
> >
> > --
> > Matt Sicker <boards@gmail.com>
> >
>



-- 
Matt Sicker <boards@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message