From general-return-63157-archive-asf-public=cust-asf.ponee.io@incubator.apache.org Mon Jan 22 15:08:01 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 2047E180609 for ; Mon, 22 Jan 2018 15:08:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0F6A0160C4B; Mon, 22 Jan 2018 14:08:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2D385160C3A for ; Mon, 22 Jan 2018 15:08:00 +0100 (CET) Received: (qmail 59824 invoked by uid 500); 22 Jan 2018 14:07:58 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 59800 invoked by uid 99); 22 Jan 2018 14:07:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jan 2018 14:07:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8D96C1A027E for ; Mon, 22 Jan 2018 14:07:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.898 X-Spam-Level: * X-Spam-Status: No, score=1.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id bWcrJQVQHSBM for ; Mon, 22 Jan 2018 14:07:53 +0000 (UTC) Received: from mail-io0-f171.google.com (mail-io0-f171.google.com [209.85.223.171]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 977595F473 for ; Mon, 22 Jan 2018 14:07:53 +0000 (UTC) Received: by mail-io0-f171.google.com with SMTP id p188so9499135ioe.12 for ; Mon, 22 Jan 2018 06:07:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=g5/3ikR3Fvjzz7rti7htcG8yHNaiRWxDS9SSegZYJVU=; b=Mt4Io32f4IK8xFyZvqnSwQ5fgBQ01SV4V083YgDG2i8bq+pa/nw+NubQV4OOUJjLu0 V3LOdW3e3/9ppinY3+NOUMZCcpNrCoMg9LFZiB9GEvWzVvhdW5IXpo86jIEsIZku/PDi oE32zKrMPtl2K78JoutQTimGBEbL1JiYfHs6WvS9fObkm3Enn8FXJg5Y0xbZwjZwwSM8 cQ/IsJFUUuC8dIPzVfd6stKN6cyq0NW6aVAvdjuHwhBQbf2C9ycBfodcflBIK5qmF6Bh pXtgVgg+7II+Szo/CKkGw3FZ8PhzPdGieAtNobsk6UtDP5Evg8xwj2SvOC5X3pljRUzx YiYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=g5/3ikR3Fvjzz7rti7htcG8yHNaiRWxDS9SSegZYJVU=; b=mZef3IIepZPYF8f7+kPcuHg9TqxJoouUsxFCE8sjmcGW7V9TVtrnh7APH85V6R1qV4 ONtvAHw27YYASfMmGJIX30yZ2CN88iUbNJZHl3jwDqzLOzk82Q5EL0BgqfsBCi3CSb+P zD4u+qM7HJWJtF6nkQd6p61Q2nU88Jt8o1owOfcmFgtOQDcT9QkcvRq0vY63xe9puPDp vX6T37VWVPtRKy/iwt7cXL4Ww6mlkAdEBbbsKOuzKtSrORZ4pDRPdUVTFv3E7pPGmHoX BqWQb9zgA2A6YeXyoS3SoBNdFf53mSjR/fKD5L5y+VYpcnx61+E/BNPy7rBACe92pUS3 +OiQ== X-Gm-Message-State: AKwxytfv9GBLHwPvbtZTPPzGEoJiyuQmj3N5xRi6BJ1qH7jhjBvIOkDH py829nXYb5aDyrwLgIEI2WwgVKpxbZ8vfM8ecJslMg== X-Google-Smtp-Source: AH8x227X2rDAnKY5oKuzBNAw+wv4G2v9lPyC7KVGO4BWysVX0a5BWEbkfHuXoiEtumWfpGJc5X4shk9NgMh5KpQLq2I= X-Received: by 10.107.144.197 with SMTP id s188mr8048704iod.92.1516630072786; Mon, 22 Jan 2018 06:07:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.101.79 with HTTP; Mon, 22 Jan 2018 06:07:52 -0800 (PST) In-Reply-To: References: <3DDEFD4A-7277-4AAA-86AF-369A4F4C6BDA@classsoftware.com> <5F33BAF7-FA55-4FFE-84B4-3D165E2A2A47@me.com> <4434418F-10C0-4328-980B-82B3F6E94204@classsoftware.com> From: Jan Lahoda Date: Mon, 22 Jan 2018 15:07:52 +0100 Message-ID: Subject: Re: License headers on test data (was Re: [VOTE] Release Apache NetBeans 9.0 Beta (incubating) rc2) To: general@incubator.apache.org Content-Type: multipart/alternative; boundary="94eb2c0560c8be85eb05635df48d" --94eb2c0560c8be85eb05635df48d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 22, 2018 at 1:56 PM, John D. Ament wrote: > > > > > > > - Specific call outs in the README about test data licensing not be > > Apache > > > license > > > > > > > This is one of the things that are very unclear to me. If we are talkin= g > > about files like these [1][2][3][4][5][6] (they may appear to differ, b= ut > > they actually are all the same: test data), then I believe these were > part > > of the initial donation and I don't have a reason to believe these are > not > > under the Apache license. Of course we could list them in the README, b= ut > > if that's a requirement, I'd suggest to fix: > > https://www.apache.org/legal/src-headers.html#faq-exceptions > > > > to include that requirement to avoid further confusion. > > > > > I've seen you post this link several times now in this thread. I > personally have no idea what you'd like to get updated on this page, and > the IPMC cannot help you get that updated, only the legal committee can. > > I'm assuming that some of your concerns are around bullet #2 "Test data f= or > which the addition of a source header would cause the tests to fail." Th= e > problem looking at this statement vs the file actually in source: > > https://github.com/apache/incubator-netbeans/blob/ > master/diff/test/unit/src/org/netbeans/modules/diff/builtin/ > provider/DiffTestFile1a.txt > > It includes a license header "Sun Public License". This line in the > I agree this is bad. (I think it was not found by the re-licensing tools because the header is broken.) document is saying to exclude the header, but you're including a SPL > header. Ultimately, at this point you can't remove the header since it's > already been declared and was not included in the relicensing of Netbeans > to Apache License. > Not sure why is that. There appear to be 2 (3) files with this header, used by a single testcase, I am pretty sure we can solve that. > > Or am I miss understanding your points around changing this document? > Sorry, I guess I misunderstood. If there's no other problem with test data, we can trivially fix this one, and there won't be any problem. Should there be any other problem with the test data, please let us know. Thanks for finding the SPL problem, Jan > > > > > > > - Specific call outs somewhere that the XSDs, ENTs, etc are derived > from > > > other locations > > > > > > > I've sent an e-mail to dev@netbeans asking those to be resolved. > > > > Thanks, > > Jan > > > > [1] > > > > https://github.com/apache/incubator-netbeans/blob/ > master/java.hints/test/unit/data/org/netbeans/test/java/ > hints/AddCast1.java > > [2] > > > > https://github.com/apache/incubator-netbeans/blob/ > master/java.hints/test/unit/data/goldenfiles/org/netbeans/ > modules/java/hints/errors/ErrorHintsTest/testAddCastHint1-hints.pass > > [3] > > > > https://github.com/apache/incubator-netbeans/blob/ > master/java.hints/test/unit/data/goldenfiles/org/netbeans/ > modules/java/hints/errors/ErrorHintsTest/testAddCastHint1.pass > > [4] > > > > https://github.com/apache/incubator-netbeans/blob/ > master/java.completion/test/unit/data/goldenfiles/org/ > netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/ > intVarName.pass > > [5] > > > > https://github.com/apache/incubator-netbeans/blob/ > master/java.completion/test/unit/data/goldenfiles/org/ > netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/empty.pass > > [6] > > > > https://github.com/apache/incubator-netbeans/blob/ > master/java.completion/test/unit/data/goldenfiles/org/ > netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/ > CreateConstructorNonDefaultConstructor.pass > > > > > > > > > > > > Gj > > > > > > > > On Monday, January 22, 2018, Justin Mclean > > > > > wrote: > > > > > > > > > Hi, > > > > > > > > > > > I am not sure what the point is of spending time on putting rat > > > > > exclusions > > > > > > together if they=E2=80=99re simply going to be ignored when it = comes to > > IPMC > > > > > > members evaluating a release. > > > > > > > > > > Rat exclusions are fine if they comply with policy and don=E2=80= =99t hide > > > things. > > > > > I=E2=80=99ve reviewed and voted on 300+ releases on the IPMC list= so > perhaps > > I > > > > have > > > > > some advice to give that you should listen to. You can of course > > choose > > > > to > > > > > ignore it. > > > > > > > > > > > Yes, we can of course discuss those rat exclusions. No, they > cannot > > > > > simply be ignored and we cannot be confronted > > > > > > with a very long list of issues in the IPMC vote thread primari= ly > > > based > > > > > on > > > > > > the fact that our rat exclusions have been ignored. > > > > > > > > > > Some of the issues I=E2=80=99ve brought up are minor and can be f= ixed in > > later > > > > > releases and some IMO are not and are not in line with ASF > licensing > > or > > > > > release policy. I suggest you try are fix those. > > > > > > > > > > > I would like this to be affirmed by the IPMC and I would like o= ur > > > > > mentors to advise on their perspective on this too. > > > > > > > > > > That would be a good way forward. As I said said previously your > > > mentors > > > > > can vote +1 on this release - my vote is not a veto. I would be > > totally > > > > > fine if you got 3 +1 votes from other IPMC members and my vote i= s > > the > > > > only > > > > > -1.That=E2=80=99s how Apache works. > > > > > > > > > > Thanks, > > > > > Justin > > > > > ------------------------------------------------------------ > --------- > > > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > > > > > For additional commands, e-mail: general-help@incubator.apache.or= g > > > > > > > > > > > > > > > > > > > > --94eb2c0560c8be85eb05635df48d--