From general-return-63183-archive-asf-public=cust-asf.ponee.io@incubator.apache.org Tue Jan 23 14:46:49 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id BBDAC180621 for ; Tue, 23 Jan 2018 14:46:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AB601160C39; Tue, 23 Jan 2018 13:46:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CA3BD160C17 for ; Tue, 23 Jan 2018 14:46:48 +0100 (CET) Received: (qmail 60016 invoked by uid 500); 23 Jan 2018 13:46:47 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 60004 invoked by uid 99); 23 Jan 2018 13:46:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jan 2018 13:46:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1E02B1A03A2 for ; Tue, 23 Jan 2018 13:46:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.121 X-Spam-Level: X-Spam-Status: No, score=-0.121 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 29rVHR6IKZJC for ; Tue, 23 Jan 2018 13:46:44 +0000 (UTC) Received: from mail-qt0-f170.google.com (mail-qt0-f170.google.com [209.85.216.170]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C68375F1F3 for ; Tue, 23 Jan 2018 13:46:43 +0000 (UTC) Received: by mail-qt0-f170.google.com with SMTP id g14so1343171qti.2 for ; Tue, 23 Jan 2018 05:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Wh4i0hs6y9W7ZlLIRIkF846qAc0MNOd5Cu4rmCZV1Zo=; b=qFf5z5rc5/3ZrbRrzWi2jLllwcMmnst2qrxksWNlXhNgayLA1IAt0nwWBRT+qpKTvN XR9PO7rdxC68fbWVDzUnlDGLIBnXzhYnADJuqi9VQfZsLzuLHFM5q+iivwHKIpvfkJQc AzjLazdJRe+pNWbIgjCkN4k/7aqPW+WnEWUPPjqcM86Epjdx+ARwskIFFVznSzsRrEAd RPYCpW/hhX2yzzKjOGgpNgp7EhLS9nATHuXl+vcYHK2d129Qb2bAdDHxGfz9rWnCFQgz IU8XjFt6nmK+4DOvQJDfFmXHfBxfBguKwFKO2xVYfDu+KRsVRnm/Mez/pVDMLGNcpz7k mJ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Wh4i0hs6y9W7ZlLIRIkF846qAc0MNOd5Cu4rmCZV1Zo=; b=HSLWSrF7gxph6l8qTHLCMHSJOfV/HXfnnroazNyzThE2cC6qF7TXD1jPckYyj0LoEp 2RKt/hMckAS5dOFyIr4V3UT1SsQkNo7yXN1ZhXJLjVjpXVVwFur5YsryjGwJ0xiRZrcB G6Fg/OcYgcZBzqEauDEQ1Zcboiih5PotFvaGEbGPWZ8o2z4atBiBxYO3tGQtdvxMY2+k k3D7j4wKrh79MFFalIeSr3rTxQCwKbA1cB/n9dPmuXMzJlo2ZOrXC4AtpN2i/cGLU+TQ MGZYone0nwwl49Y/f6rMN28u0B3QQV0L5TcGPBTB4ST2zJpukRc85axBh5flBX+O+1ge zrgg== X-Gm-Message-State: AKwxytfXrj9mCFCdLWQjN7Ida3MQXh9JwZR4GEV12xhWRO1xbP8Y+mcB JHP5ILQ+tyi+BbcxdVLNfShy78SuPe/LtLh4kZ0= X-Google-Smtp-Source: AH8x224aH9iZpQMg+z9jTrdoTtamjdK8QoTgAyN1G9WLX32BVSFbjTTYxUck19yqhlg1vTc8X6z6EmFPmt6CJ4JGON4= X-Received: by 10.55.195.219 with SMTP id r88mr3350066qkl.219.1516715202966; Tue, 23 Jan 2018 05:46:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.167.18 with HTTP; Tue, 23 Jan 2018 05:46:42 -0800 (PST) In-Reply-To: References: <3DDEFD4A-7277-4AAA-86AF-369A4F4C6BDA@classsoftware.com> <5F33BAF7-FA55-4FFE-84B4-3D165E2A2A47@me.com> <4434418F-10C0-4328-980B-82B3F6E94204@classsoftware.com> From: Geertjan Wielenga Date: Tue, 23 Jan 2018 14:46:42 +0100 Message-ID: Subject: Re: License headers on test data (was Re: [VOTE] Release Apache NetBeans 9.0 Beta (incubating) rc2) To: general@incubator.apache.org Content-Type: text/plain; charset="UTF-8" OK, makes sense, thanks for these insights and ideas. Gj On Tue, Jan 23, 2018 at 2:40 PM, Bertrand Delacretaz wrote: > Hi, > > On Tue, Jan 23, 2018 at 2:35 PM, Geertjan Wielenga > wrote: > >>... >> https://github.com/apache/incubator-netbeans/blob/master/nbbuild/build.xml >> This is what line 2105 says: >> ... > > Maybe grouping those exclusions by families would make it easier for > reviewers to understand them: first the ones which are not creative, > then those where a header would cause tests to fail etc. > >> ...You're saying the comment isn't needed in the README... > > What I'm saying is that it shouldn't be duplicated - have the README > point to that build.xml file,or as discussed a file that just has RAT > exclusions, and add the comments next to the exclusions, pointing to > apache.org docs where useful. > >> ...can NETBEANS-306 be closed as resolved?... > > I suggest grouping the exclusions that fall in that family and adding > a pointer to the Apache docs that mention that the header is not > required if it causes tests to fail. > > You then get links from README -> commented RAT exclusions -> Apache > documentation which provide a clear justification. > > -Bertrand > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > For additional commands, e-mail: general-help@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org For additional commands, e-mail: general-help@incubator.apache.org