incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geertjan Wielenga <geertjan.wiele...@googlemail.com>
Subject Re: License headers on test data (was Re: [VOTE] Release Apache NetBeans 9.0 Beta (incubating) rc2)
Date Tue, 23 Jan 2018 13:22:49 GMT
We have created one of many[1] issues dedicated to data files in
*/test/*data folders.

The point is that these are all data files, used by our tests, and if
license headers were to be added the tests would fail.

E.g., some tests make use of a position in the file, which would be
different (and wrong) if a license header were to be added.

Hence this should apply:
https://www.apache.org/legal/src-headers.html#faq-exceptions

And we propose that we add a line to the README that says:
"*/test/*/data folders contain test data and therefore may have no
license headers".

https://issues.apache.org/jira/browse/NETBEANS-306

What needs to be done to resolve this issue?

Thanks,

Gj

[1]https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+9.0+Beta+rc3

On Mon, Jan 22, 2018 at 3:43 PM, John D. Ament <johndament@apache.org> wrote:
> On Mon, Jan 22, 2018 at 9:41 AM Jaroslav Tulach <jaroslav.tulach@gmail.com>
> wrote:
>
>> I'd like to focus on the actual issue found, leaving the overall discussion
>> aside...
>>
>> > ...
>> > I'm assuming that some of your concerns are around bullet #2 "Test data
>> for
>>
>> > which the addition of a source header would cause the tests to fail."
>> The
>> > problem looking at this statement vs the file actually in source:
>> >
>> > https://github.com/apache/incubator-netbeans/blob/
>> > master/diff/test/unit/src/org/netbeans/modules/diff/builtin/
>> > provider/DiffTestFile1a.txt
>> >
>> > It includes a license header "Sun Public License".  This line in the
>> > document is saying to exclude the header, but you're including a SPL
>> > header.
>>
>>
>> Obviously a mistake. Here is a fix:
>> https://github.com/apache/incubator-netbeans/pull/381
>>
>>
>> > Ultimately, at this point you can't remove the header since it's
>> > already been declared and was not included in the relicensing of Netbeans
>> > to Apache License.
>> >
>>
>> I don't understand why I should not be allowed to fix omitted ancient
>> license that hasn't been fixed yet?
>>
>
> Simply my interpretation of the fact the header wasn't fixed.  If it was an
> oversight, that's fine.
>
>
>>
>> Best regards and keep an eye on what we do! Thanks for your findings.
>> -jt
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message